[email protected] on npm does not match 1.7.1 source on GitHub

[kmashint]

Expected behaviour

npm install [email protected] using https://registry.npmjs.org/ should have the same package.json dependencies as the karma-1.71.zip.

Actual behaviour

$ npm view [email protected] dist.tarball
https://registry.npmjs.org/karma/-/karma-1.7.1.tgz
$ curl -o karma-1.7.1-npm.com.tgz https://registry.npmjs.org/karma/-/karma-1.7.1.tgz
And then inspecting the tgz file it shows package.json dependencies with lodash: ^3.8.0 instead of ^4.x.y.

Environment Details

$ node --version
v6.11.1
$ npm --version
3.10.10

Steps to reproduce the behaviour

As above.

Is this a problem in publishing to registry.npmjs.org?

[johnjbarton]

Yes, the npm distribution is somehow messed up.

The github source package.json
https://github.com/karma-runner/karma/blob/master/package.json
has
"version": "1.7.0",
and dependencies including:
"lodash": "^4.17.4",
But the npm distro has package.json with
version 1.7.1
and dependencies including:
"lodash": "^3.8.0",

How can we fix this?

[johnjbarton]

I think the problem here is that the 1.7.1 branch is not merged into HEAD

[EzraBrooks]

I renamed this issue to make it more general, as there are other issues caused by this failed deployment.

[dignifiedquire]

karma 1.7.1 is correct on npm. 1.7.1 was released with "old" lodash@3 because moving to 4 is breaking change. master contains multiple breaking changes, so I cut a release for 1.7.1 which only contains this commit. The branch 1.7.1 is incorrect now as master was never supposed to be merged into it, only the tag is correct.

[wilsonge]

@dignifiedquire can you clean up the fact there are multiple tags for 1.7.1 then - and not containing the same source code - v1.7.1...1.7.1

Also can you update the changelog https://github.com/karma-runner/karma/blob/master/CHANGELOG.md#171-2017-08-25 to reflect what you said above :)

[dignifiedquire]

@wilsonge thank you for pointing that out, should be fixed now and tags correct

[wilsonge]

Thanks :)