Typescript files (.ts) are marked as binary files

[ondrejsevcik]

Hi, I'm using karma with preprocessor for typescript and since this 8a30cf5 commit its not possible to use typescript files with default .ts extension.

[drkibitz]

See 3rd string in this line https://github.com/karma-runner/karma/blob/master/lib/preprocessor.js#L21

I was worried about extension collisions in the back of my mind @vojtajina, and here is one, is it a "Transport Stream" or "TypeScript" file? This is where something like mime-magic can help, but it is quite a large dependency to introduce. There's gotta be a better way to do this :/

[dignifiedquire]

There is https://www.npmjs.org/package/isbinaryfile

[drkibitz]

@dignifiedquire I like it, have you tried it?

[dignifiedquire]

Yes I've been using it in production without problems for over a month now.

[drkibitz]

Would like @vojtajina to weigh in before a pull request ;)

[vojtajina]

Can somebody do a benchmark of isbinaryfile? Compare to just checking the path as we do now? Because for the purpose of Karma, in 99.9% time it's not a binary file. And if you preprocess thousands of files I dont' wanna slow it down.

As a quick fix for now, I would remove the ts from binary extensions.

[ondrejsevcik]

I've created simple benchmark https://github.com/ondrejsevcik/isbinaryfile-benchmark

It tests a few npm packages, but I'm not 100% sure that this test is adequate so please check it out.
Results are below

[vojtajina]

Fixed by 8269852.