From 4c95296b3bd321e471d864fc75aa66fa3f1aa1fc Mon Sep 17 00:00:00 2001 From: Joey Parrish Date: Mon, 25 Jul 2022 11:15:12 -0700 Subject: [PATCH] fixed the Wrong caption icon 2 #4358 --- .github/workflows/build-and-test.yaml | 5 +++-- ui/text_selection.js | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-and-test.yaml b/.github/workflows/build-and-test.yaml index de78fcb05d..3ba88957ce 100644 --- a/.github/workflows/build-and-test.yaml +++ b/.github/workflows/build-and-test.yaml @@ -86,10 +86,11 @@ jobs: run: | # Download Safari 14 # See also https://www.macupdate.com/app/mac/15675/apple-safari/old-versions - curl -Lv https://www.macupdate.com/action/download/63550 > safari-14.1.2.pkg + curl -Lv https://www.macupdate.com/action/download/62946 > Safari14.0CatalinaAuto.pkg.zip # Install Safari 14 to homedir specifically. - installer -pkg safari-14.1.2.pkg -target CurrentUserHomeDirectory + unzip Safari14.0CatalinaAuto.pkg.zip + installer -pkg Safari14.0CatalinaAuto.pkg -target CurrentUserHomeDirectory # Install a launcher that can execute a shell script to launch this npm install karma-script-launcher --save-dev diff --git a/ui/text_selection.js b/ui/text_selection.js index baa6f79c61..ed85caeffd 100644 --- a/ui/text_selection.js +++ b/ui/text_selection.js @@ -111,11 +111,11 @@ shaka.ui.TextSelection = class extends shaka.ui.SettingsMenu { onCaptionStateChange_() { if (this.player.isTextTrackVisible()) { this.icon.textContent = - shaka.ui.Enums.MaterialDesignIcons.CLOSED_CAPTIONS_OFF; + shaka.ui.Enums.MaterialDesignIcons.CLOSED_CAPTIONS; this.button.ariaPressed = 'true'; } else { this.icon.textContent = - shaka.ui.Enums.MaterialDesignIcons.CLOSED_CAPTIONS; + shaka.ui.Enums.MaterialDesignIcons.CLOSED_CAPTIONS_OFF; this.button.ariaPressed = 'false'; }