Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all references to rpcuser, rpcpass, rpccert, and rpckey #1614

Open
stasatdaglabs opened this issue Mar 16, 2021 · 3 comments
Open

Remove all references to rpcuser, rpcpass, rpccert, and rpckey #1614

stasatdaglabs opened this issue Mar 16, 2021 · 3 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@stasatdaglabs
Copy link
Collaborator

The above CLI flags are a relic from BTCD, and are no longer relevant.
Go over the entire codebase and remove all references to them.

@stasatdaglabs stasatdaglabs added this to the 0.12.0 milestone Mar 16, 2021
@svarogg svarogg added the good first issue Good for newcomers label May 18, 2021
@svarogg
Copy link
Collaborator

svarogg commented May 18, 2021

AFAICT rpcuser and rpcpass are already gone.

@cdnsteve
Copy link

rpccert and rpckey are still referenced but it looks like these might be useful in the auth story if we choose TLS as noted in #1893
Any context on the purpose of these, just old legacy? Better to remove and start over?

@someone235
Copy link
Collaborator

rpccert and rpckey are still referenced but it looks like these might be useful in the auth story if we choose TLS as noted in #1893 Any context on the purpose of these, just old legacy? Better to remove and start over?

These are legacy flags, but they can be useful for #1893. So it's the choice of who implements #1893 if to use them, or remove them and use something slightly different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants