Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push promises can't have a streamed response #19

Open
acastello opened this issue Jul 10, 2020 · 1 comment
Open

Push promises can't have a streamed response #19

acastello opened this issue Jul 10, 2020 · 1 comment
Assignees
@kazu-yamamoto

Comments

@acastello
Copy link

If you use responseStreaming when building the body of a push promise, the client receives a RSTStreamFrame InternalError (tested with the http2-client-exe package). This is caused by a fromJust in the frameSender function: Push promises with a streamed body are not output with a stream queue so the current implementation just crashes.
@kazu-yamamoto kazu-yamamoto self-assigned this Jul 12, 2020
@kazu-yamamoto
Copy link
Owner

@acastello Thank you for pointing out. Could you fix it by yourself and send a PR? I'm busy in this week because of QUIC interop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazu-yamamoto kazu-yamamoto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kazu-yamamoto @acastello