Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpolate messages without values #282

Merged
merged 1 commit into from
Jan 24, 2018
Merged

Conversation

cb8
Copy link
Contributor

@cb8 cb8 commented Jan 20, 2018

In some cases, a custom formatter might need to format a message despite no additional values. For example due to branding or personalization requirements.

@codecov-io
Copy link

codecov-io commented Jan 20, 2018

Codecov Report

Merging #282 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #282      +/-   ##
==========================================
+ Coverage   96.09%   96.11%   +0.01%     
==========================================
  Files           9        9              
  Lines         615      617       +2     
==========================================
+ Hits          591      593       +2     
  Misses         24       24
Impacted Files Coverage Δ
src/format.js 100% <100%> (ø) ⬆️
src/index.js 99.56% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e63178...07d6fb9. Read the comment docs.

Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

Could you update flowtype please?

https://github.com/kazupon/vue-i18n/blob/dev/decls/i18n.js#L107

@cb8
Copy link
Contributor Author

cb8 commented Jan 24, 2018

👍 done

@kazupon kazupon merged commit b792ce2 into kazupon:dev Jan 24, 2018
@cb8 cb8 deleted the interpolate-all branch January 25, 2018 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants