Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 bug(index): evaluate availabilities lazily (fix #477) #483

Merged
merged 1 commit into from
Dec 15, 2018

Conversation

gamtiq
Copy link
Contributor

@gamtiq gamtiq commented Dec 14, 2018

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #483 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #483      +/-   ##
==========================================
+ Coverage   96.64%   96.65%   +0.01%     
==========================================
  Files           9        9              
  Lines         655      657       +2     
==========================================
+ Hits          633      635       +2     
  Misses         22       22
Impacted Files Coverage Δ
src/util.js 98.18% <ø> (-0.07%) ⬇️
src/index.js 99.63% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4a8c27...ec65665. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Dec 14, 2018

Codecov Report

Merging #483 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #483      +/-   ##
==========================================
+ Coverage   96.64%   96.65%   +0.01%     
==========================================
  Files           9        9              
  Lines         655      657       +2     
==========================================
+ Hits          633      635       +2     
  Misses         22       22
Impacted Files Coverage Δ
src/util.js 98.18% <ø> (-0.07%) ⬇️
src/index.js 99.63% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4a8c27...ec65665. Read the comment docs.

Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! good job! 👍

@kazupon kazupon merged commit b66f02e into kazupon:dev Dec 15, 2018
@gamtiq gamtiq deleted the fix-477 branch December 15, 2018 20:15
@exoego
Copy link
Collaborator

exoego commented Jan 4, 2019

@gamtiq
FYI, the issue #477 has a fund on IssueHunt https://issuehunt.io/repos/19382828/issues/477
If you submit this PR that resolved #477, you can grab the fund.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants