-
-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implemented new i18n-n functional component #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazupon
approved these changes
Mar 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! 💯
Thank you very much!
This was referenced Mar 25, 2019
xuhongbo
added a commit
to xuhongbo/vue-i18n
that referenced
this pull request
Mar 25, 2019
* ⭐ new(path): Keypath should parse if sub path contains spaces. (kazupon#533) by @exoego * feat(path): Keypath should parse if sub path contains spaces. * feat(path): Added test for whitespaces * 📝 docs(vuepress): pluralization will not work unless you use $tc (kazupon#540) by @lebesnec * ⭐ new(number): i18n-n functional component (kazupon#541) by @bponomarenko
kazupon
pushed a commit
that referenced
this pull request
Mar 27, 2019
closes #531 * docs: add vuepress zh docs config * docs(zh/README.md): Translation README.md file * docs(zh/README.md): Translation installation.md file * docs: Translation introduction.md file * docs: Translation started.md file * docs: 更改称谓 * docs: Translation api/README.md file * style: values type * fix: pluralization -> 多元化 * fix: locale translation * docs: Translation api/formatting file * docs: Translation guide/pluralization.md file * fixed: fix type * docs: All translation completed * Update vuepress/.vuepress/config.js 参照Vue的规范修正译文中的格式 Co-Authored-By: xuhongbo <[email protected]> * fix: type * fix: 区域设置 -> 语言环境 * style: Modify the format including punctuation and spaces * fix: 修复vuepress config * Update if not ..., check ... -> 如果没有则 Co-Authored-By: xuhongbo <[email protected]> * Update 主语前置 Co-Authored-By: xuhongbo <[email protected]> * Update 完善用语 Co-Authored-By: xuhongbo <[email protected]> * Update 语义更明确 Co-Authored-By: xuhongbo <[email protected]> * fix: Correct the format to remove extra spaces * update: 提示 -> tip * Update vuepress/zh/api/README.md Co-Authored-By: xuhongbo <[email protected]> * 更改主谓 Co-Authored-By: xuhongbo <[email protected]> * 提高句子的可读性 Co-Authored-By: xuhongbo <[email protected]> * 提高句子的可读性 Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/api/README.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/api/README.md Co-Authored-By: xuhongbo <[email protected]> * fix: Fix some keyword errors and various issues * update: Optimize text for readability * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/hot-reload.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/interpolation.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/interpolation.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/interpolation.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/interpolation.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/interpolation.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/lazy-loading.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/lazy-loading.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/lazy-loading.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/locale.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/locale.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/locale.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/lazy-loading.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/lazy-loading.md Co-Authored-By: xuhongbo <[email protected]> * 区域 -> 语言环境, 消息 -> 信息 * Update vuepress/zh/guide/messages.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/messages.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/messages.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/messages.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/number.md Co-Authored-By: xuhongbo <[email protected]> * fix: Locale Messages -> 语言环境信息 * 同步源仓库到Fock仓库 (#1) * ⭐ new(path): Keypath should parse if sub path contains spaces. (#533) by @exoego * feat(path): Keypath should parse if sub path contains spaces. * feat(path): Added test for whitespaces * 📝 docs(vuepress): pluralization will not work unless you use $tc (#540) by @lebesnec * ⭐ new(number): i18n-n functional component (#541) by @bponomarenko * Revert "同步源仓库到Fock仓库 (#1)" (#2) This reverts commit 8f8a88b. * Update vuepress/zh/guide/pluralization.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/pluralization.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/pluralization.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <[email protected]> * style: code style * Update vuepress/zh/installation.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/installation.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/installation.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/installation.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/installation.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/installation.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/introduction.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/introduction.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/introduction.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/introduction.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/started.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/started.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/started.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/started.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/started.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/legacy/README.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/legacy/README.md Co-Authored-By: xuhongbo <[email protected]> * Update vuepress/zh/legacy/README.md Co-Authored-By: xuhongbo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements feature proposal from #539.
@kazupon It was not possible to have
key
property for the<i18n-n>
component as it is reserved keyword in Vue itself. I defined it asformat
property instead, and renamedkey
toformat
inside documentation forn()
and$n()
methods for consistency. Hope it is ok with you (no code changes, it is only documentation update).