-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
imp(YAML Errors): vastly improves error messages when using YAML
When errors are made while developing, the panic error messages have been improved instead of relying on the default panic message which is extremely unhelpful. Closes #574
- Loading branch information
Showing
7 changed files
with
153 additions
and
122 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
name: yml_app | ||
version: 1.0 | ||
version: "1.0" | ||
about: an example using a .yml file to build a CLI | ||
author: Kevin K. <[email protected]> | ||
|
||
|
@@ -69,7 +69,7 @@ subcommands: | |
# Rust code later | ||
- subcmd: | ||
about: demos subcommands from yaml | ||
version: 0.1 | ||
version: "0.1" | ||
author: Kevin K. <[email protected]> | ||
# Subcommand args are exactly like App args | ||
args: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
|
||
macro_rules! yaml_vec_or_str { | ||
($v:ident, $a:ident, $c:ident) => {{ | ||
let maybe_vec = $v.as_vec(); | ||
if let Some(vec) = maybe_vec { | ||
for ys in vec { | ||
if let Some(s) = ys.as_str() { | ||
$a = $a.$c(s); | ||
} else { | ||
panic!("Failed to convert YAML value {:?} to a string", ys); | ||
} | ||
} | ||
} else { | ||
if let Some(s) = $v.as_str() { | ||
$a = $a.$c(s); | ||
} else { | ||
panic!("Failed to convert YAML value {:?} to either a vec or string", $v); | ||
} | ||
} | ||
$a | ||
} | ||
}; | ||
} | ||
|
||
macro_rules! yaml_to_str { | ||
($a:ident, $v:ident, $c:ident) => {{ | ||
$a.$c($v.as_str().unwrap_or_else(|| panic!("failed to convert YAML {:?} value to a string", $v))) | ||
}}; | ||
} | ||
|
||
macro_rules! yaml_to_bool { | ||
($a:ident, $v:ident, $c:ident) => {{ | ||
$a.$c($v.as_bool().unwrap_or_else(|| panic!("failed to convert YAML {:?} value to a string", $v))) | ||
}}; | ||
} | ||
|
||
macro_rules! yaml_to_u64 { | ||
($a:ident, $v:ident, $c:ident) => {{ | ||
$a.$c($v.as_i64().unwrap_or_else(|| panic!("failed to convert YAML {:?} value to a string", $v)) as u64) | ||
}}; | ||
} | ||
|
||
macro_rules! yaml_to_usize { | ||
($a:ident, $v:ident, $c:ident) => {{ | ||
$a.$c($v.as_i64().unwrap_or_else(|| panic!("failed to convert YAML {:?} value to a string", $v)) as usize) | ||
}}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
name: claptests | ||
version: 1.0 | ||
version: "1.0" | ||
about: tests clap library | ||
author: Kevin K. <[email protected]> | ||
settings: | ||
|
@@ -81,7 +81,7 @@ arg_groups: | |
subcommands: | ||
- subcmd: | ||
about: tests subcommands | ||
version: 0.1 | ||
version: "0.1" | ||
author: Kevin K. <[email protected]> | ||
args: | ||
- scoption: | ||
|