Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible values verification doesn't work #287

Closed
grossws opened this issue Sep 29, 2015 · 5 comments
Closed

Possible values verification doesn't work #287

grossws opened this issue Sep 29, 2015 · 5 comments
Labels
A-parsing Area: Parser's logic and needs it changed somehow. C-bug Category: Updating dependencies
Milestone
1.4.3

Comments

@grossws
Copy link
Contributor

grossws commented Sep 29, 2015

Can be reproduced using example 11_only_specific_values.

actual

If invoked with any value (other than fast and slow) it triggers panic:
thread '<main>' panicked at 'internal error: entered unreachable code', src/main.rs:32

expected

Some error message, graceful exit and usage info printed.
@kbknapp
Copy link
Member

kbknapp commented Sep 30, 2015

Thanks for taking the time to file this! We'll post back here with updates and should have this fixed quickly.

@kbknapp kbknapp added C-bug Category: Updating dependencies P1: urgent A-parsing Area: Parser's logic and needs it changed somehow. labels Sep 30, 2015
@kbknapp kbknapp added this to the 1.4.3 milestone Sep 30, 2015
@kbknapp
Copy link
Member

kbknapp commented Sep 30, 2015

Offending lines are most likely here

I'll fix in the morning if someone hasn't beaten me to it by then 😉

kbknapp added a commit that referenced this issue Sep 30, 2015
@kbknapp
fix(Possible Values): possible value validation is restored
f121ae7 
Closes #287
@kbknapp kbknapp mentioned this issue Sep 30, 2015
Merged
homu added a commit that referenced this issue Sep 30, 2015
@homu
Auto merge of #288 - kbknapp:issue-287, r=sru
5d7ce3e 
fix(Possible Values): possible value validation is restored

Closes #287
@homu homu closed this as completed in #288 Sep 30, 2015
@grossws
Copy link
Contributor Author

grossws commented Sep 30, 2015

👍

@kbknapp
Copy link
Member

kbknapp commented Sep 30, 2015

@grossws Once #289 merges I'll release 1.4.3 to crates.io

@kbknapp
Copy link
Member

kbknapp commented Sep 30, 2015

v1.4.3 is out on crates.io which fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parsing Area: Parser's logic and needs it changed somehow. C-bug Category: Updating dependencies
Projects
None yet
Milestone
1.4.3
Development

No branches or pull requests
2 participants
@grossws @kbknapp