-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Less quoting in error messages #309
Comments
This was originally set up because of args that have spaces in them ( For now, I'd say we leave the current implementation, but I'm open to opposing arguments if you can sway me 😉 |
Would this be printed like this:
Not sure I understand the possible confusion. |
I've been thinking about this specifically since you mentioned it, and the more I think about it the more I agree with you. The quoting does add additional noise for little to no gain. I think what I was originally "worried" about could otherwise be passed off as poor CLI design anyways...and I'm not sure we need to be in the business of catering to every edge case. The "poor design" I'm thinking of is a single positional argument with more than one value.
But like I said, that's a stretch and super edge case. I'll edit this title and remove quoting from certain instances tracking for 1.4.6. @birkenfeld (and all) what's your thought on quoting inside error sentences? I.e. |
@kbknapp I think quoting inside error sentences is fine. |
I agree. |
fix(Errors): tones down quoting in some error messages Closes #309 Turns out it's just a single message which quotes outside a sentence.
IMO this is a bit too much quoting:
Either
'pattern'
or<pattern>
would be enough.The text was updated successfully, but these errors were encountered: