Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArgRequiredElseHelp should take precedence over required args #362

Closed
WiSaGaN opened this issue Dec 17, 2015 · 7 comments
Closed

ArgRequiredElseHelp should take precedence over required args #362

WiSaGaN opened this issue Dec 17, 2015 · 7 comments
Labels
A-parsing Area: Parser's logic and needs it changed somehow. C-bug Category: Updating dependencies
Milestone
1.5.4

Comments

@WiSaGaN
Copy link

WiSaGaN commented Dec 17, 2015

Currently, if we have required args present and no args are provided at run-time, clap will output an error message even if ArgRequiredElseHelp is set in the app setting.
Providing the usage without error is more friendly in this case, especially when we supply ArgRequiredElseHelp.
@Vinatorul Vinatorul added C-bug Category: Updating dependencies C: args A-parsing Area: Parser's logic and needs it changed somehow. labels Dec 17, 2015
@kbknapp
Copy link
Member

kbknapp commented Dec 18, 2015

Thanks for taking the time to file this, I agree it should work that way. We should have this fixed and put up a new version shortly!

kbknapp added a commit that referenced this issue Dec 18, 2015
@kbknapp
fix: ArgRequiredElseHelp setting now takes precedence over missing re…
faad83f 
…quired args

Closes #362
@kbknapp kbknapp mentioned this issue Dec 18, 2015
Merged
@kbknapp kbknapp added this to the 1.5.4 milestone Dec 18, 2015
@WiSaGaN
Copy link
Author

WiSaGaN commented Dec 18, 2015

Thanks for fixing this. And so fast!

@homu homu closed this as completed in #363 Dec 18, 2015
homu added a commit that referenced this issue Dec 18, 2015
@homu
Auto merge of #363 - kbknapp:issue-362, r=Vinatorul
e886a52 
fix: ArgRequiredElseHelp setting now takes precedence over missing re…

…quired args

Closes #362
@kbknapp
Copy link
Member

kbknapp commented Dec 18, 2015

No problem, I'll bump the version and publish 1.5.4 to crates.io 😉

@Vinatorul
Copy link
Contributor

@kbknapp do not forget to create tag 😉

@kbknapp
Copy link
Member

kbknapp commented Dec 18, 2015

I'd like to say I won't forget...but I always do 😜

@kbknapp
Copy link
Member

kbknapp commented Dec 18, 2015

v1.5.4 is out on crates.io now

...and tag created!

@WiSaGaN
Copy link
Author

WiSaGaN commented Dec 18, 2015

Awesome!

@iKevinY iKevinY mentioned this issue Mar 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parsing Area: Parser's logic and needs it changed somehow. C-bug Category: Updating dependencies
Projects
None yet
Milestone
1.5.4
Development

No branches or pull requests
3 participants
@WiSaGaN @Vinatorul @kbknapp