Cannot use custom --version with DisableVersion

[anna-is-cute]

Rust Version

rustc 1.18.0-nightly (5e122f59b 2017-04-01)

Affected Version of clap

clap 2.22.2

Expected Behavior Summary

Overriding --version should allow use of a custom version flag.

Actual Behavior Summary

The default version provided by clap is used.

Steps to Reproduce the issue

Specify an Arg with short("v") and long("version").

Sample Code or Link to Sample Code

extern crate clap;

use clap::{App, Arg, AppSettings};

fn main() {
  let matches = App::new("clap-bug")
    .setting(AppSettings::DisableVersion)
    .arg(Arg::with_name("version")
      .short("v")
      .long("version")
      .help("custom version"))
    .get_matches();

  println!("{}", matches.is_present("version"));
}

Debug output

Output

[kbknapp]

Thanks for taking the time to file this! I do have a question however; why are you using DisableVersion? You can override the default --version by only supplying an arg with a long of version.

As I understand it, and please correct me if I'm wrong, this would be an area where I could improve the docs.

[anna-is-cute]

From what I understood, you needed to use DisableVersion to override the default --version, but now I know that it's not necessary! I agree that a note in the docs would be helpful to clear any misunderstandings.

I can still reproduce the issue when not using DisableVersion, though.

[kbknapp]

Ah ok, then that is a bug!