Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a subcommand to print complete recipe for an app #120

Open
PrasadG193 opened this issue Aug 5, 2021 · 7 comments · May be fixed by #136
Open

Add a subcommand to print complete recipe for an app #120

PrasadG193 opened this issue Aug 5, 2021 · 7 comments · May be fixed by #136
Labels
good first issue Good for newcomers

Comments

@PrasadG193
Copy link
Member

The command could be like - kbrew recipe kafka which should print complete recipe details for better understanding or debugging

@PrasadG193 PrasadG193 added the good first issue Good for newcomers label Aug 5, 2021
@sahil-lakhwani
Copy link
Contributor

I think we can use the info command by having a sub-command or a flag (--verbose). Thoughts?

@JOSHUAJEBARAJ
Copy link

I would llike to work on this issue, Let me know how we can take forward this issue

@sahil-lakhwani
Copy link
Contributor

hey @JOSHUAJEBARAJ 👋
You might want to look at the implementation of the info command - it does a similar job of printing a summary of a recipe. This issue is for printing the complete recipe.

While we work to build a contributing guide, you can use the Makefile to build the binary from the source (make build) after you make any changes
Let us know if you need any help!

@JOSHUAJEBARAJ
Copy link

Hey Sahil 👋
I had look at the info Command Can You explain what is the additional information you want to print

For example the kbrew info argo-cd gives the below output

repository:
  name: argo
  url: https://argoproj.github.io/argo-helm
  type: helm
version: 3.6.2

THe registry config looks like something like this for the argo-cd

apiVersion: v1
kind: kbrew
app:
  repository:
    name: argo
    url: https://argoproj.github.io/argo-helm
    type: helm
  namespace: "argocd"
  sha256:
  version: 3.6.2

What are the additional detail it should Print ?

@sahil-lakhwani
Copy link
Contributor

Taking an example the longhorn recipe, kbrew info prints only the metadata which has pre/post install apps. With a new command/sub-command we would like to print the entire recipe, which also includes steps, args, etc. So basically the recipe as it is in the file.
We can do it as a new command to kbrew or a new subcommand to info - kbrew info all for example

@deepankur797
Copy link

@JOSHUAJEBARAJ are you still working on this issue ? If not, may I take this forward and start working on it.

@JOSHUAJEBARAJ
Copy link

@deepankur797 Sure You can go ahead and work on this issue

@Akshit42-hue Akshit42-hue linked a pull request Oct 13, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants