Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dry run flag support for install #129

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added dry run flag support for install #129

wants to merge 2 commits into from

Conversation

deepankur797
Copy link

Used the skip approach , if dry run flag is set.

Example Usage

kbrew install longhorn --dry-run

@sahil-lakhwani sahil-lakhwani linked an issue Dec 8, 2021 that may be closed by this pull request
Add support for dry run #99
Open
@sahil-lakhwani
Copy link
Contributor

hey @deepankur797 , I tried this and could see output as below:

🚀 Installing longhorn app...
Version: 
Pre-install dependencies: 
Post-install dependencies: 
 - ingress-nginx
---
Application to install longhorn 

Application Type helm 
Application URL https://charts.longhorn.io 

Pre Install Dependencies

Manifest 
openssl version 

Manifest 
: "${USERNAME:?Variable USERNAME not set or empty}" : "${PASSWORD:?Variable PASSWORD not set or empty}" 

Manifest 
curl -s https://raw.githubusercontent.com/longhorn/longhorn/v1.1.1/scripts/environment_check.sh | bash 

Manifest 
kubectl apply -f https://raw.githubusercontent.com/longhorn/longhorn-manager/master/deploy/prerequisite/longhorn-iscsi-installation.yaml 

Post Install Dependencies

Application ingress-nginx

Manifest 
kubectl -n longhorn-system create secret generic basic-auth --from-literal=auth=$(echo ${USERNAME}:$(echo ${PASSWORD} | openssl passwd -stdin -apr1))

Few things:

  • The dry-run option should print everything which will be installed, even the arguments. It should also evaluate the Go templates which show the actual values that will be used.
  • I am wondering if it should also detail the helm apps.

About the visuals

  • The first 5 lines of the above output seem repetitive
  • Some separator would be good to have, like `Application Type : helm
  • All steps are labelled as manifests, which should not be the case
  • Some separation between, pre/post installs would be good to have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

@sahil-lakhwani sahil-lakhwani Awaiting requested review from sahil-lakhwani

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for dry run
2 participants
@deepankur797 @sahil-lakhwani