Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong value in plist #61

Closed
taniguti opened this issue Sep 17, 2018 · 3 comments
Closed

Wrong value in plist #61

taniguti opened this issue Sep 17, 2018 · 3 comments

Comments

@taniguti
Copy link
Collaborator

Hi,

I think it must be integer, mount of seconds but there is a string 'Aqua'.

<key>TimeOut</key>
<integer>Aqua</integer>

I'm not sure how much mount of time is reasonable. But how about 600 or so.

Best regards,

@taniguti
Copy link
Collaborator Author

This will be fixed by @scifiman PR #67. thanks

@kc9wwh
Copy link
Owner

kc9wwh commented Sep 23, 2018

This was actually what was expected in 10.12 and worked in my 10.13 testing.
#13 (comment)

But I honestly don't know how to reverse engineer what Apple is doing here, so if it works in testing I'm willing to accept the PR. Hopefully will have time this week to review all the code changes and test.

@kc9wwh
Copy link
Owner

kc9wwh commented Sep 25, 2018

Thank you @taniguti for your help! This is actually very helpful and I love it! :)

@kc9wwh kc9wwh closed this as completed Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants