Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsygu filter broken for non-translocations #100

Closed
kdm9 opened this issue Jul 13, 2024 · 4 comments
Closed

dsygu filter broken for non-translocations #100

kdm9 opened this issue Jul 13, 2024 · 4 comments

Comments

@kdm9
Copy link
Contributor

kdm9 commented Jul 13, 2024

Hello,

I think some recent refactoring of filter_normal.py has broken dysgu filter. I suspect the cause is that process_intra() never returns None. From a brief inspection of dysgu filter --keep-all it seems to complain about low support for all non-TRA events. I tried to track the logic of process_intra() but ran out of time.

I've confirmed that version 1.6.2 works as expected, but nothing since then does, so I suspect the bug is somewhere here.

I've already made a PR for a bug that prevented using --keep-all since v1.6.2, #99.

best,
K

@kcleal
Copy link
Owner

kcleal commented Jul 13, 2024

Hi @kdm9,
Thanks for raising this, I will get this fixed asap.
Would you be able to share details of how you run used dysgu run/call + filter commands, and what read-type you are working with (Illumina, nanopore etc ..) Thanks!

@kdm9
Copy link
Contributor Author

kdm9 commented Jul 14, 2024

many thanks @kcleal, I've reached out by email to provide these details.

@kcleal kcleal mentioned this issue Jul 14, 2024
@kcleal
Copy link
Owner

kcleal commented Jul 15, 2024

v1.6.6 has been released - I think the issue should be resolved, but let me know if it still exists. v1.6.6 is on once, but not yet on Pypi.

@kcleal kcleal closed this as completed Jul 15, 2024
@kdm9
Copy link
Contributor Author

kdm9 commented Jul 18, 2024

Just confirming that in our hands, dysgu filter is working again now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants