-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dsygu filter broken for non-translocations #100
Comments
Hi @kdm9, |
many thanks @kcleal, I've reached out by email to provide these details. |
v1.6.6 has been released - I think the issue should be resolved, but let me know if it still exists. v1.6.6 is on once, but not yet on Pypi. |
Just confirming that in our hands, |
Hello,
I think some recent refactoring of filter_normal.py has broken
dysgu filter
. I suspect the cause is thatprocess_intra()
never returns None. From a brief inspection ofdysgu filter --keep-all
it seems to complain about low support for all non-TRA events. I tried to track the logic ofprocess_intra()
but ran out of time.I've confirmed that version
1.6.2
works as expected, but nothing since then does, so I suspect the bug is somewhere here.I've already made a PR for a bug that prevented using
--keep-all
since v1.6.2, #99.best,
K
The text was updated successfully, but these errors were encountered: