Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: flake: e2e framework data race #2693

Closed
stevekuznetsov opened this issue Jan 27, 2023 · 0 comments · Fixed by #2694
Closed

bug: flake: e2e framework data race #2693

stevekuznetsov opened this issue Jan 27, 2023 · 0 comments · Fixed by #2694
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@stevekuznetsov
Copy link
Contributor

Describe the bug

 ==================
WARNING: DATA RACE
Read at 0x00c000015a50 by goroutine 194:
  github.com/kcp-dev/kcp/test/e2e/framework.newWorkspaceFixture[...].func2()
      /go/src/github.com/kcp-dev/kcp/test/e2e/framework/workspaces.go:156 +0x253
  testing.(*common).Cleanup.func1()
      /usr/local/go/src/testing/testing.go:1041 +0x193
  testing.(*common).runCleanup()
      /usr/local/go/src/testing/testing.go:1210 +0x143
  testing.tRunner.func2()
      /usr/local/go/src/testing/testing.go:1440 +0x52
  runtime.deferCallSave()
      /usr/local/go/src/runtime/panic.go:796 +0x87
  testing.(*T).FailNow()
      <autogenerated>:1 +0x37
  github.com/stretchr/testify/require.Eventually()
      /go/pkg/mod/github.com/stretchr/[email protected]/require/require.go:364 +0xde
  github.com/kcp-dev/kcp/test/e2e/framework.Eventually()
      /go/src/github.com/kcp-dev/kcp/test/e2e/framework/util.go:327 +0x266
  github.com/kcp-dev/kcp/test/e2e/framework.newWorkspaceFixture[...]()
      /go/src/github.com/kcp-dev/kcp/test/e2e/framework/workspaces.go:159 +0xa16
  github.com/kcp-dev/kcp/test/e2e/framework.NewWorkspaceFixture()
      /go/src/github.com/kcp-dev/kcp/test/e2e/framework/workspaces.go:189 +0x137
  github.com/kcp-dev/kcp/test/e2e/conformance.TestCRDCrossLogicalClusterListPartialObjectMetadata()
      /go/src/github.com/kcp-dev/kcp/test/e2e/conformance/cross_logical_cluster_list_test.go:145 +0x6ee
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1446 +0x216
  testing.(*T).Run.func1()
      /usr/local/go/src/testing/testing.go:1493 +0x47
Previous write at 0x00c000015a50 by goroutine 4932:
  github.com/kcp-dev/kcp/test/e2e/framework.newWorkspaceFixture[...].func3()
      /go/src/github.com/kcp-dev/kcp/test/e2e/framework/workspaces.go:161 +0x16e
  github.com/kcp-dev/kcp/test/e2e/framework.Eventually.func1()
      /go/src/github.com/kcp-dev/kcp/test/e2e/framework/util.go:330 +0x87
  github.com/stretchr/testify/assert.Eventually.func1()
      /go/pkg/mod/github.com/stretchr/[email protected]/assert/assertions.go:1691 +0x39
Goroutine 194 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1493 +0x75d
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:1846 +0x99
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1446 +0x216
  testing.runTests()
      /usr/local/go/src/testing/testing.go:1844 +0x7ec
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1726 +0xa84
  main.main()
      _testmain.go:59 +0x2e9
Goroutine 4932 (finished) created at:
  github.com/stretchr/testify/assert.Eventually()
      /go/pkg/mod/github.com/stretchr/[email protected]/assert/assertions.go:1691 +0x3a5
  github.com/stretchr/testify/require.Eventually()
      /go/pkg/mod/github.com/stretchr/[email protected]/require/require.go:361 +0xb8
  github.com/kcp-dev/kcp/test/e2e/framework.Eventually()
      /go/src/github.com/kcp-dev/kcp/test/e2e/framework/util.go:327 +0x266
  github.com/kcp-dev/kcp/test/e2e/framework.newWorkspaceFixture[...]()
      /go/src/github.com/kcp-dev/kcp/test/e2e/framework/workspaces.go:159 +0xa16
  github.com/kcp-dev/kcp/test/e2e/framework.NewWorkspaceFixture()
      /go/src/github.com/kcp-dev/kcp/test/e2e/framework/workspaces.go:189 +0x137
  github.com/kcp-dev/kcp/test/e2e/conformance.TestCRDCrossLogicalClusterListPartialObjectMetadata()
      /go/src/github.com/kcp-dev/kcp/test/e2e/conformance/cross_logical_cluster_list_test.go:145 +0x6ee
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1446 +0x216
  testing.(*T).Run.func1()
      /usr/local/go/src/testing/testing.go:1493 +0x47
================== 

Steps To Reproduce

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/kcp-dev_kcp/2690/pull-ci-kcp-dev-kcp-main-e2e-sharded/1618731879718981632

Expected Behaviour

.

Additional Context

No response

@stevekuznetsov stevekuznetsov added the kind/bug Categorizes issue or PR as related to a bug. label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant