Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fallback logic in formula-based evaluation #5684

Merged
merged 10 commits into from
Apr 24, 2024
Merged

Fix fallback logic in formula-based evaluation #5684

merged 10 commits into from
Apr 24, 2024

Conversation

SpiritZhou
Copy link
Contributor

@SpiritZhou SpiritZhou commented Apr 11, 2024 •
edited by zroubalik
Loading

Fixed fallback logic in formula-based evaluation and return the correct metric value

Checklist

Fixes #5666

@SpiritZhou
Fix fallback logic
bf1db6b 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
5ae09a2 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Fix changelog
36b95db 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou SpiritZhou requested a review from a team as a code owner April 11, 2024 11:01
JorTurFer
JorTurFer reviewed Apr 11, 2024
View reviewed changes
pkg/scaling/scale_handler.go Show resolved Hide resolved
pkg/scaling/modifiers/formula.go Outdated Show resolved Hide resolved
@SpiritZhou
Update
e9a6bf6 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
8bb4c4e 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Apr 17, 2024 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@tomkerkhove
Copy link
Member

@SpiritZhou can you fix conflict please?

@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Apr 23, 2024 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@zroubalik zroubalik mentioned this pull request Apr 23, 2024
Closed
35 tasks
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Apr 24, 2024 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

JorTurFer
JorTurFer reviewed Apr 24, 2024
View reviewed changes
pkg/scaling/scale_handler.go Show resolved Hide resolved
pkg/scaling/modifiers/formula.go Outdated Show resolved Hide resolved
@JorTurFer JorTurFer enabled auto-merge (squash) April 24, 2024 09:45
@zroubalik
Copy link
Member

zroubalik commented Apr 24, 2024 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@JorTurFer JorTurFer merged commit e41294d into kedacore:main Apr 24, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The replica count of target pods fluctuates when fallback is triggered in scaling-modifier
4 participants
@SpiritZhou @tomkerkhove @zroubalik @JorTurFer