Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kedro-airflow: Incorrect node names in created DAGs #544

Closed
ankatiyar opened this issue Feb 7, 2024 · 0 comments · Fixed by #594
Closed

kedro-airflow: Incorrect node names in created DAGs #544

ankatiyar opened this issue Feb 7, 2024 · 0 comments · Fixed by #594
Assignees
Labels
airflow bug Something isn't working

Comments

@ankatiyar
Copy link
Contributor

Description

This bug is not in the released version of kedro-airflow 0.8.0 but possibly introduced in one of the recent PRs after the release.

The node names in tasks in the DAGs generated by kedro-airflow have hyphens instead of underscores which are mean that the node names are not valid.

Context

What is generated now -

  "preprocess-companies-node": KedroOperator(
            task_id="preprocess-companies-node",
            package_name=package_name,
            pipeline_name=pipeline_name,
            node_name="preprocess-companies-node",
            project_path=project_path,
            env=env,
        ),

What should be generated (and previously was) -

"preprocess-companies-node": KedroOperator(
            task_id="preprocess-companies-node",
            package_name=package_name,
            pipeline_name=pipeline_name,
            node_name="preprocess_companies_node",
            project_path=project_path,
            env=env,
        ),

Steps to Reproduce

  1. Make a new kedro project with spaceflights-pandas starter
  2. Install kedro-airflow from the main branch
  3. kedro airflow create
@ankatiyar ankatiyar added the bug Something isn't working label Feb 7, 2024
@ankatiyar ankatiyar changed the title bug(airflow): Incorrect node names in created DAGs kedro-airflow: Incorrect node names in created DAGs Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airflow bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant