Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter framework logging.yml configuration #1470

Closed
Tracked by #1461
antonymilne opened this issue Apr 22, 2022 · 2 comments · Fixed by #1491
Closed
Tracked by #1461

Alter framework logging.yml configuration #1470

antonymilne opened this issue Apr 22, 2022 · 2 comments · Fixed by #1491
Assignees

Comments

@antonymilne
Copy link
Contributor

antonymilne commented Apr 22, 2022

Various small changes to make to the framework kedro/config/logging.yml (not to the project conf/base/logging.yml):

  • delete the section root
  • add the kedro.io and kedro.pipeline that are in project conf/base/logging.yml to the framework kedro/config/logging.yml
  • add the following to the loggers:
kedro:
  level: INFO
  handlers: [console, info_file_handler, error_file_handler]
  propagate: no

Do some kedro runs to make sure things look ok. I'm pretty sure they will.

@antonymilne antonymilne changed the title Default logging setup should not change the default root setup. Default logging setup should not change the default root setup Apr 22, 2022
@antonymilne antonymilne changed the title Default logging setup should not change the default root setup Alter default logging setup Apr 22, 2022
@antonymilne antonymilne changed the title Alter default logging setup Alter framework logging.yml configuration Apr 22, 2022
@merelcht merelcht added this to the Improve logging setup milestone Apr 25, 2022
@merelcht
Copy link
Member

merelcht commented Apr 28, 2022

Might fix the kedro-airflow problem, double check this is the case.

@AhdraMeraliQB AhdraMeraliQB self-assigned this Apr 29, 2022
@AhdraMeraliQB AhdraMeraliQB linked a pull request Apr 29, 2022 that will close this issue
5 tasks
@antonymilne
Copy link
Contributor Author

Slightly different, new and improved version of this in 83b074f:

  • keep the root logger but no longer change its level to INFO (it will keep the default of WARNING)
  • kedro logger just changes the level to INFO, which propagates to the root logger
  • the only special case is kedro.framework.cli.hooks.manager, where we don't want to write to a file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants