-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we allow users provide custom session_id
#1551
Comments
So it looks simple enough to make this a parameter of the create method... Is the question that we need to ensure that custom I think this has a lot of user value, both Airflow and Prefect users have raised this. |
@datajoely Implementation-wise should be simple, but I remember the team discussed related topics when we have the 1 session = 1 run changes 2 months ago. There are probably more discussions before that, so I don't have the full context. Personally, I think this is a very practical use case.
Yes for this too, we need to ensure they are monotonic to make sure versioning works. |
I wonder if there is any merit in a |
@atmosone I have copied your comments here so we can track it in 1 issue, hope this is fine. |
Updated the issue to facilitate future tech design session. |
session_id
Just so we have all this in one place - this is very relevant: #1273 |
Discussed in Technical Design on 27/7 DiscussionAs part of the discussion we talked about the following points:
ConclusionThe outcome of the discussion was that we will allow users to provide a custom Implementation |
Closing this issue in favour of the action points mentioned above. |
I would add that we should update the Prefect deployment guide too |
Description
This was originally a thread from Discord
Is your feature request related to a problem? A clear and concise description of what the problem is: "I'm always frustrated when ..."
When using an orchestrator like Airflow, kedro nodes are run with multiple sessions and it is hard to organise the output dataset since all of them have different timestamps.
Context
(Edited on Jun16)
Use Case
KedroSession
. Logging of all I/O related to a particular session IDsession_id
for various logging purposePossible Implementation
session_id
inKedroSession.create()
?session_id
other than the default timestamp? (Joel has a suggestion that allow user to add suffix so it won't change the order but give more flexibility for user to add metadata.)save_version = session_id
still valid? Parametrized session_id #1571KedroSession.reset()
to create a newsession
easily? - this can potentially make the Jupyter workflow nicer. Instead of asking user to create their session with lots of details, they can just take the globalsession
and dosession.reset()
Parametrized session_id #1571(Optional) Suggest an idea for implementing the addition or change.
workarounds or changes in
kedro
framework side.Possible Alternatives
(Optional) Describe any alternative solutions or features you've considered.
The text was updated successfully, but these errors were encountered: