Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor load version logic #1654

Open
merelcht opened this issue Jun 29, 2022 · 3 comments · Fixed by #1911
Open

Refactor load version logic #1654

merelcht opened this issue Jun 29, 2022 · 3 comments · Fixed by #1911
Assignees
@noklam
Milestone
Dataset Versioning

Comments

@merelcht
Copy link
Member

merelcht commented Jun 29, 2022 •
edited by noklam
Loading

Background

Pre-requisite for #1580

The code for loading the latest data/fetching the load version needs further refactoring. resolve_load_version is called multiple times, where it probably shouldn't. Moreover, inside kedro-viz we have replicated some of the logic to load the latest data for experiment tracking, which should be improved as well.
@merelcht merelcht mentioned this issue Jun 29, 2022
Open
@antonymilne
Copy link
Contributor

Here's one part of kedro-viz where I'm confident a refactoring would make things cleaner. There may be others as well.
https://github.com/kedro-org/kedro-viz/blob/b2011d5b34fdcc7e02974a8c0834c2d70a7dc27f/package/kedro_viz/models/graph.py#L639-L691

@antonymilne antonymilne mentioned this issue Jul 6, 2022
Closed
@antonymilne antonymilne mentioned this issue Aug 10, 2022
Open
@antonymilne
Copy link
Contributor

After this is completed, we should consider what to do with #1691. e.g. should we show load=None or the actual load version?

@noklam noklam mentioned this issue Oct 17, 2022
Merged
5 tasks
@noklam noklam linked a pull request Oct 17, 2022 that will close this issue
Remove redundant resolve_load_version call #1911
Merged
5 tasks
@noklam
Copy link
Contributor

noklam commented Oct 21, 2022 •
edited
Loading

Reopen as it's only partly done

@noklam noklam reopened this Oct 21, 2022
@merelcht merelcht added this to the Redesign Catalog and Datasets milestone Feb 6, 2023
@noklam noklam mentioned this issue Feb 8, 2023
Closed
6 tasks
@astrojuanlu astrojuanlu mentioned this issue Jun 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noklam noklam

Labels
None yet
Projects
Kedro Framework
Status: No status
Milestone
Dataset Versioning
Development

Successfully merging a pull request may close this issue.

Remove redundant resolve_load_version call kedro-org/kedro
3 participants
@noklam @antonymilne @merelcht