You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[@AntonyMilneQB] Let’s investigate how other libraries are handling similar situations. e.g. I believe the idea for kedro-datasets might have been inspired by how django packages different components (?). @deepyaman mentioned jupyter’s metapackage approach. Again, maybe what we are doing is the best approach, but I would like to feel more confident about this. Just as we missed the possibility of namespace packages in the first place, maybe we’re missing something big here
[@deepyaman]
Agree that it would make sense to see/learn from the experience of more projects here. If somebody can find/share how Django does this, that would be great, because I haven't found it yet. :) While I think the metapackage approach sounds clean in theory, I wonder if it's overcomplicating things, if Kedro-Framework is essentially required, and Kedro-Datasets is the only additional package. Also, which (if any) of these approaches expect the underlying packages to be independent, and which support packages depending on each other (possibly again going back to the question of avoiding circular dependencies)?
Maybe there is a whole different way of handling the kedro vs. kedro-datasets split which would resolve the question of dependencies, what a user should pip install, how to handle the namespace, etc. e.g. @deepyaman suggested a kedro metapackage in which kedro-framework and kedro-datasets are both namespaced packages underneath that.
We don’t need to commit to implementing the kedro-framework split now if we don’t want to, but I think it would be good to get a feeling for whether this a route we might want to go down in future because it influences our current decision on how to handle kedro-datasets. e.g. it might convince us that pip install kedro[pandas.CSVDataSet] is good or bad.
The text was updated successfully, but these errors were encountered:
antonymilne
changed the title
Explore how other packages handle dependencies
Explore how other (meta-)packages handle dependencies
Aug 10, 2022
We will not further pursue this approach for now as it seems like overkill to make Kedro into a metapackage structure. Further details and discussion can be seen under #1758.
Copying relevant parts from #1758...
Maybe there is a whole different way of handling the
kedro
vs.kedro-datasets
split which would resolve the question of dependencies, what a user shouldpip install
, how to handle the namespace, etc. e.g. @deepyaman suggested akedro
metapackage in whichkedro-framework
andkedro-datasets
are both namespaced packages underneath that.We don’t need to commit to implementing the
kedro-framework
split now if we don’t want to, but I think it would be good to get a feeling for whether this a route we might want to go down in future because it influences our current decision on how to handlekedro-datasets
. e.g. it might convince us thatpip install kedro[pandas.CSVDataSet]
is good or bad.The text was updated successfully, but these errors were encountered: