-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kedro run CLI incorrectly splits the names of nodes at commas #1828
Comments
Linking this issue to #1795. This happens when node |
As discussed in backlog grooming, this is a very long-standing issue bug and it would be nice to get it fixed. I've looked through our old Jira board to get the previous discussion for context too. Possible solutions here:
Overall I like (in order): option 5/3, 4, 1, 2. We don't need to solve this part at the same time, but just for completeness, let me note here part of the previous discussion that questioned how kedro automatically generates a name for a node. There was research piece on this done before but I'm not sure what the outcome was - we'd need @yetudada or @idanov for this I think. Some options I vaguely recall though:
Side-note: personally I'm not a big fan of exactly how the current automatic node name is formatted. What do the square brackets add? Why is there no space after the comma? I think this is a historical hangover from the days when kedro inputs had to be specified as a list. If we decide we want to do one of these then fixing the case with commas will likely become irrelevant, because an automatically generated node name would no longer have a comma in it. Possibly we should still consider doing option 5 above though for consistency. |
This was discussed in Technical Design
The actions to be done after this dicussion:
|
Closing this issue in favour of the follow up actions from Tech Design. |
Description
Running kedro with the command
kedro run --from-nodes "two_inputs([A0,B0]) -> [C1]"
will cause an error:Pipeline does not contain nodes named ['B0]) -> [C1]', 'two_inputs([A0'].
Kedro has incorrectly split the name of the intended
Node
into the names of twoNode
s that do not exist.Context
This bug prevents the user from re-running kedro from any
Node
with a comma in its name. This is the case for anyNode
that is not explicitly given a name and has more than one input.Steps to Reproduce
kedro run --from-nodes 'My node, a good node'
)Pipeline does not contain nodes named ['a good node', 'My node'].
Expected Result
Kedro should try to run from the node with the specified name.
Actual Result
Kedro attempts to run from multiple nodes, with names drawn from the result of splitting the intended
Node
name at commas.The text was updated successfully, but these errors were encountered: