Casing Consistency: Rename TensorFlowModelDataset to ...DataSet

[BrianCechmanek]

Description

TensorFlowModelDataset is the only included dataset not following the "DataSet" casing consistency.

Context

Maintaining consistency assists with mental overhead.

Possible Implementation

I believe the fix is just a refactor in the 7 instances across the following two files:

• ./extras/datasets/tensorflow/tensorflow_model_dataset.py
• ./extras/datasets/tensorflow/__init__.py:__all__

I am happy to submit a PR of the refactor, if appropriate.

Possible Alternatives

It may have been intentional to break convention for this DataSet. Searching open and closed Issues, I found no reference.

NB : I believe I followed the contributing guide correctly. Please let me know if not - first ever OS Issue submission :)

[deepyaman]

@BrianCechmanek Great catch! It's not intentional (AFAIK), just an oversight. :) You're welcome to make a PR, but please do so on https://github.com/kedro-org/kedro-plugins instead (the new home from datasets).

[deepyaman]

It would also be nice to make everything SomethingSomethingDataset in the future, to be most consistent (see #533), but that would be outside the scope of this PR (and probably should be aligned with the broader team).

[BrianCechmanek]

Tubular!

1. Will get on this (PR to plugins, per your comment)
2. Is there any consideration like a deprecation warning for changing Dataset -> DataSet ?

[deepyaman]

2. Is there any consideration like a deprecation warning for changing Dataset -> DataSet ?

I don't think it's necessary for datasets, but let me confirm...

[astrojuanlu]

See #2129

[BrianCechmanek]

Thanks @astrojuanlu - sorry I missed that.

Sounds like that's a much bigger task (and probably above my head). I think this can be safely closed, then.

[deepyaman]

@BrianCechmanek I think it may be fine to go ahead with this, since the massive change will probably have to wait until 0.19 release, while this could help improve consistency in the shorter term. But maybe we can just wait for a confirmation on this; don't want you to do work unnecessarily. :)