Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ConfigLoader and TemplatedConfigLoader #2692

Closed
5 tasks
merelcht opened this issue Jun 15, 2023 · 2 comments · Fixed by #3253
Closed
5 tasks

Remove ConfigLoader and TemplatedConfigLoader #2692

merelcht opened this issue Jun 15, 2023 · 2 comments · Fixed by #3253

Comments

@merelcht
Copy link
Member

merelcht commented Jun 15, 2023

Description

OmegaConfigLoader will be the config loader from 0.19.0 onwards.

Context

https://github.com/kedro-org/kedro/milestone/34

To do:

  • Remove ConfigLoader
  • Remove TemplatedConfigLoader
  • Remove all other code related to these config loaders
  • Remove any docs about these loaders and re-order the OmegaConfigLoader content where needed.
  • Can we remove the anyconfig dependency? Double check if any other parts of our codebase are using it.
@merelcht merelcht changed the title Remove ConfigLoader and TemplatedConfigLoader and all related code Remove ConfigLoader and TemplatedConfigLoader Aug 29, 2023
@astrojuanlu
Copy link
Member

A few of places that still use anyconfig:

try:
metadata_dict = anyconfig.load(pyproject_toml)

import anyconfig # for performance reasons
config_dict = anyconfig.load(metadata.config_file)

if value:
config = anyconfig.load(value)[section]

@ankatiyar
Copy link
Contributor

Closed with #3253 and #3257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants