Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Packaged Kedro Project entrypoint __main__.py, move _find_run_command to Framework #3051

Closed
noklam opened this issue Sep 19, 2023 · 2 comments · Fixed by #4012
Closed
Labels
Issue: Feature Request New feature or improvement to existing feature

Comments

@noklam
Copy link
Contributor

noklam commented Sep 19, 2023

Description

kedro new ship a __main__.py which is the default way to run a packaged Kedro Project with python -m <project>. Currently we expose a function that loads the run command in the project. This should be move to the framework.

https://github.com/kedro-org/kedro-starters/blob/87715c48977bdfe1c64dd1d924a9f3e6c0933951/pandas-iris/%7B%7B%20cookiecutter.repo_name%20%7D%7D/src/%7B%7B%20cookiecutter.python_package%20%7D%7D/__main__.py#L11-L36

Context

This make upgrading Kedro Project is hard because we leave code in user project.

Possible Implementation

Possible Alternatives

@noklam noklam added the Issue: Feature Request New feature or improvement to existing feature label Sep 19, 2023
@noklam
Copy link
Contributor Author

noklam commented Sep 19, 2023

Cc @idanov Could you supplement what was the challenge that we need to solve to move this back to framework?

@idanov
Copy link
Member

idanov commented Jul 12, 2024

I believe that the only challenge is to figure out what is the best and most user-friendly way to import the run function from kedro.framework.project and if we can make it behave in the same way as kedro.framework.pipelines, i.e. lazily loaded and configured only after configure_project is called before it is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Feature Request New feature or improvement to existing feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants