Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leading zeros in hours #11

Closed
RinkAttendant6 opened this issue Jan 12, 2016 · 4 comments
Closed

Leading zeros in hours #11

RinkAttendant6 opened this issue Jan 12, 2016 · 4 comments

Comments

@RinkAttendant6
Copy link

It would be convenient to have an option to disable the leading zero in the hours item

@kemar
Copy link
Owner

kemar commented Jan 13, 2016

Seems legit :)

However this can be easily achieved with a custom CSS rule.

I'm not planning to add this possibility in the code but feel free to fork the project if you really need a way to do it via JavaScript.

@kemar kemar closed this as completed Jan 13, 2016
@RinkAttendant6
Copy link
Author

Fair enough, though would you mind sharing an appropriate CSS rule as the one I came up with seems quite hack-ish:

time[datetime*='H0'] .hh-1 {
    /* styles here */
}

It isn't critical for me, just thought I'd throw it out there.

@kemar
Copy link
Owner

kemar commented Jan 13, 2016

Sorry, after thinking again I may have overlooked the issue.

Hiding elements based on their content is not possible via CSS.

So a JavaScript based solution is the way to go.

I'm currently thinking about providing an option to disable leading zeros for hours, minutes and seconds.

I'm reopening this issue pending a decision concerning this option.

@kemar kemar reopened this Jan 13, 2016
@kemar kemar closed this as completed in 97464a2 Dec 23, 2016
@kemar
Copy link
Owner

kemar commented Dec 23, 2016

@RinkAttendant6 It's been a long time coming, but I finally made it 🐼 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants