Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions #20

Open
madsmtm opened this issue Nov 23, 2021 · 2 comments
Open

Questions #20

madsmtm opened this issue Nov 23, 2021 · 2 comments

Comments

@madsmtm
Copy link
Contributor

madsmtm commented Nov 23, 2021

Hey, I've opened a few PRs against this repo because we intend to use it in the future in objc (see SSheldon/rust-objc#72), and in my fork of that project.

So, I have a few questions regarding the code:

  • Have you considered whether the unstable #[may_dangle] is appropriate for MBox?
  • It is generally a good idea to add #[inline] on smaller functions, especially on forwarding implementations, have you considered this?
  • The file structure is a bit unorthodox compared to most rust projects (mostly that test functions live outside a #[cfg(test)] mod tests) - would you be open to PRs refactoring this?

And a few regarding the project itself:

  • Would you be open to relicensing under a dual MIT / Apache 2.0 license?
  • This crate is currently lacking the high quality documentation that c_vec has, especially regarding examples; maybe consider making some of the tests as documentation examples?
  • If you want more widespread adoption (which I generally think this crate deserves), maybe consider opening a PR against sdl2 and hyperscan.
@madsmtm
Copy link
Contributor Author

madsmtm commented Nov 23, 2021

And do you know if it will be possible, when the relevant features stabilize, to create an Allocator such that MBox could just be type MBox<T> = Box<T, MallocAllocator>?

@madsmtm
Copy link
Contributor Author

madsmtm commented Jun 19, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant