Skip to content
This repository has been archived by the owner on Jan 6, 2021. It is now read-only.

3.1.0 package has a bad build #34

Closed
ericf opened this issue Oct 4, 2016 · 3 comments
Closed

3.1.0 package has a bad build #34

ericf opened this issue Oct 4, 2016 · 3 comments

Comments

@ericf
Copy link

ericf commented Oct 4, 2016

Greekeeper failed by build because when running cross-env it couldn't find ./command.js: https://travis-ci.org/yahoo/react-intl/jobs/165011187#L192

Looking at the package on npm, it appears there's no command.js in ./dist/: https://unpkg.com/[email protected]/dist/
@kentcdodds
Copy link
Owner

Whoops, that's my bad for not reviewing properly. I'll fix that. Thanks for the report!

@EnzoMartin EnzoMartin mentioned this issue Oct 4, 2016
Closed
@EnzoMartin
Copy link
Contributor

EnzoMartin commented Oct 4, 2016 •
edited
Loading

New PR should fix it #35

@knpwrs knpwrs mentioned this issue Oct 4, 2016
Closed
@kentcdodds
Copy link
Owner

kentcdodds commented Oct 4, 2016 •
edited
Loading

Fixed, released 3.1.1, deprecated 3.1.0. Thanks!

kentcdodds referenced this issue Oct 4, 2016
@EnzoMartin
feat(vars): Convert environment vars (#32)
8da54d0 
* feat(vars): Convert environment vars
- Converts environment vars used in `npm run` to account for windows/linux respectively
- Add tests for command
- Update `npm test` to look for all .test.js files

* fix(assign): Remove lodash.assign
- Use Object.assign
@hakatashi hakatashi mentioned this issue Oct 5, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ericf @EnzoMartin @kentcdodds