Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(metrics-operator): cleanup APIs #3270

Merged
merged 1 commit into from
Mar 21, 2024
Merged

chore(metrics-operator): cleanup APIs #3270

merged 1 commit into from
Mar 21, 2024

Conversation

odubajDT
Copy link
Contributor

Depends on #3269

@odubajDT odubajDT added the on hold Do not merge yet label Mar 14, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation ops metrics-operator labels Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.02%. Comparing base (c0c4fb4) to head (d9ebd05).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3270      +/-   ##
==========================================
- Coverage   87.03%   87.02%   -0.01%     
==========================================
  Files         168      162       -6     
  Lines        8723     8665      -58     
==========================================
- Hits         7592     7541      -51     
+ Misses        839      832       -7     
  Partials      292      292              

see 7 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 58.04% <ø> (-0.49%) ⬇️
lifecycle-operator 86.50% <ø> (ø)
metrics-operator 88.32% <ø> (-0.04%) ⬇️
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT removed the on hold Do not merge yet label Mar 21, 2024
@github-actions github-actions bot removed documentation Improvements or additions to documentation ops labels Mar 21, 2024
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@odubajDT odubajDT marked this pull request as ready for review March 21, 2024 10:25
@odubajDT odubajDT requested a review from a team as a code owner March 21, 2024 10:25
@odubajDT odubajDT merged commit a683c9a into keptn:main Mar 21, 2024
39 of 40 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants