Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: move webhook section from README to docs #3314

Merged
merged 7 commits into from
Mar 21, 2024
Merged

docs: move webhook section from README to docs #3314

merged 7 commits into from
Mar 21, 2024

Conversation

odubajDT
Copy link
Contributor

Fixes: #3201

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 20, 2024
@odubajDT odubajDT marked this pull request as ready for review March 20, 2024 15:39
@odubajDT odubajDT requested review from a team as code owners March 20, 2024 15:39
StackScribe
StackScribe reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple little comments but the webhook page is nice.

Why is Scheduler left in the README rather than being merged into the "Scheduler" page in components? Or is that a separate ticket?

@odubajDT @StackScribe
Apply suggestions from code review
7503b32 
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: odubajDT <[email protected]>
mowies
mowies reviewed Mar 21, 2024
View reviewed changes
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree with @StackScribe that we can also remove the scheduler section

mkdocs.yml Outdated Show resolved Hide resolved
docs/docs/components/lifecycle-operator/webhook.md Show resolved Hide resolved
odubajDT
odubajDT commented Mar 21, 2024
View reviewed changes
README.md Show resolved Hide resolved
odubajDT
odubajDT commented Mar 21, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@odubajDT
Update README.md
97b5b18 
Signed-off-by: odubajDT <[email protected]>
mowies
mowies previously approved these changes Mar 21, 2024
View reviewed changes
@odubajDT
reorganize
4c7d7a5 
Signed-off-by: odubajDT <[email protected]>
RealAnna

This comment was marked as duplicate.

Sign in to view

RealAnna
RealAnna previously approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

way better ❤️

mowies
mowies reviewed Mar 21, 2024
View reviewed changes
docs/docs/components/lifecycle-operator/webhook.md Outdated Show resolved Hide resolved
docs/docs/components/lifecycle-operator/webhook.md Outdated Show resolved Hide resolved
docs/docs/components/lifecycle-operator/webhook.md Outdated Show resolved Hide resolved
docs/docs/components/lifecycle-operator/webhook.md Outdated Show resolved Hide resolved
docs/docs/components/lifecycle-operator/webhook.md Outdated Show resolved Hide resolved
docs/docs/components/lifecycle-operator/webhook.md Outdated Show resolved Hide resolved
docs/docs/components/lifecycle-operator/webhook.md Outdated Show resolved Hide resolved
@odubajDT @mowies
Apply suggestions from code review
e47e4c4 
Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odubajDT odubajDT merged commit e0cac27 into keptn:main Mar 21, 2024
11 checks passed
@keptn-bot keptn-bot mentioned this pull request Mar 21, 2024
Merged
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
@odubajDT @StackScribe
@mowies @Vickysomtee
docs: move webhook section from README to docs (keptn#3314)
d8f599a 
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StackScribe StackScribe StackScribe left review comments

@RealAnna RealAnna RealAnna approved these changes

@mowies mowies mowies approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move information about mutating webhook to docs
4 participants
@odubajDT @StackScribe @mowies @RealAnna