Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Thanos metrics provider #3358

Merged
merged 11 commits into from
Mar 27, 2024
Merged

feat: add Thanos metrics provider #3358

merged 11 commits into from
Mar 27, 2024

Conversation

mowies
Copy link
Member

@mowies mowies commented Mar 27, 2024

fixes #2900

@github-actions github-actions bot added metrics-operator documentation Improvements or additions to documentation ops labels Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.04%. Comparing base (25d5c06) to head (1badc4e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3358   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files         176      176           
  Lines        9604     9604           
=======================================
  Hits         8456     8456           
  Misses        854      854           
  Partials      294      294           
Files Coverage Δ
...rics-operator/api/v1/keptnmetricsprovider_types.go 66.66% <ø> (ø)
...-operator/controllers/common/providers/provider.go 100.00% <100.00%> (ø)
...trollers/common/providers/prometheus/prometheus.go 84.56% <75.00%> (ø)
Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 58.04% <ø> (ø)
lifecycle-operator 88.08% <ø> (ø)
metrics-operator 88.32% <80.00%> (ø)
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies marked this pull request as ready for review March 27, 2024 11:44
@mowies mowies requested review from a team as code owners March 27, 2024 11:44
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@odubajDT
Copy link
Contributor

Looks good, did you manage to test it also manually?

@mowies
Copy link
Member Author

mowies commented Mar 27, 2024

i did not test is manually, but i checked how Thanos is set up and it's just a sidecar for prometheus instances so it should really be not different at all compared to prometheus
source

@mowies mowies closed this Mar 27, 2024
@mowies mowies reopened this Mar 27, 2024
bacherfl
bacherfl previously approved these changes Mar 27, 2024
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odubajDT odubajDT merged commit 7cc1622 into keptn:main Mar 27, 2024
46 of 47 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation metrics-operator ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Thanos metrics provider in Keptn Metrics Operator
3 participants