-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Thanos metrics provider #3358
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3358 +/- ##
=======================================
Coverage 88.04% 88.04%
=======================================
Files 176 176
Lines 9604 9604
=======================================
Hits 8456 8456
Misses 854 854
Partials 294 294
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Looks good, did you manage to test it also manually? |
i did not test is manually, but i checked how Thanos is set up and it's just a sidecar for prometheus instances so it should really be not different at all compared to prometheus |
Signed-off-by: Moritz Wiesinger <[email protected]>
metrics-operator/controllers/common/providers/prometheus/prometheus.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Quality Gate passedIssues Measures |
Signed-off-by: Moritz Wiesinger <[email protected]> Signed-off-by: vickysomtee <[email protected]>
fixes #2900