-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm-chart): make charts Openshift compliant #3415
feat(helm-chart): make charts Openshift compliant #3415
Conversation
a9ecacc
to
76ac9c0
Compare
f7ee0cb
to
72142ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice start! Thanks for doing this. Just a few little comments on the documentation portions. The only big issue is that I think this belongs on its own page in the "Configuration" section.
To create a new page, move the contents to the contributing
sub-section and follow the instructions in https://keptn.sh/stable/docs/contribute/docs/source-file-structure/#specifying-the-doc-structure to add this file to the mkdocs.yml
file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3415 +/- ##
==========================================
+ Coverage 85.29% 85.33% +0.04%
==========================================
Files 167 167
Lines 7412 7412
==========================================
+ Hits 6322 6325 +3
+ Misses 801 799 -2
+ Partials 289 288 -1 see 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Hi @smuda thank you for your contribution! Do you please have the capacity to make the required changes in the following days? We are planning to do a release in the next days and we would like to have this fix merged until then. If you do not have the capacity, we will take over the PR. Thank you in advance! |
Thank you! I'll fix this tonight. |
@smuda thank you! |
@StackScribe Thank you for the docs changes! |
Signed-off-by: John Allberg <[email protected]>
…on Openshift. Signed-off-by: John Allberg <[email protected]>
…on Openshift. Signed-off-by: John Allberg <[email protected]>
… Openshift. Signed-off-by: John Allberg <[email protected]>
…roup if running on Openshift. Signed-off-by: John Allberg <[email protected]>
368a008
to
e36fd1b
Compare
Signed-off-by: John Allberg <[email protected]>
e36fd1b
to
e1c87c0
Compare
I rebased on top of main and handled most of your suggestions/comments. Could you please allow the rest of the tests to run? |
Not many OSS have great documentation and you have even documented how to document. Impressive and awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Some minor comments for the documentation :)
Co-authored-by: odubajDT <[email protected]> Signed-off-by: John Allberg <[email protected]>
Co-authored-by: odubajDT <[email protected]> Signed-off-by: John Allberg <[email protected]>
Co-authored-by: odubajDT <[email protected]> Signed-off-by: John Allberg <[email protected]>
Quality Gate passedIssues Measures |
Description
Allow removal of runAsUser and runAsGroup when running on openshift.
Fixes #3414
How to test
I've added a test under
.github/scripts/.helm-tests
and I hope that will run automatically together with the other tests, even though the github actions didn't run in my fork.At least
make helm-test
works nicely :-).Checklist
into multiple PRs)
see Contribution Guide
the Contribution Guide