-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: introduce blogpost of ArgoCD and Keptn integration #3521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! left a couple of suggestions but looks good already
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3521 +/- ##
==========================================
- Coverage 85.38% 85.33% -0.06%
==========================================
Files 167 167
Lines 7412 7412
==========================================
- Hits 6329 6325 -4
- Misses 796 799 +3
- Partials 287 288 +1 see 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nicely done! I left a few minor suggestions for your consideration
Thank you for your review :) |
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Quality Gate passedIssues Measures |
Should this PR have at least a bit of a description, to set a good example for other contributors if nothing else. It might also be nice if it linked to #3356 just so that issue has a comprehensive list of the work that's been done. |
Changes
This PR introduces a blogpost about the possible future integration of Argo and Keptn. It describes how these two projects can collaborate and help the end user with faster and safer delivery of software
Part-of: #3356