Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: introduce blogpost of ArgoCD and Keptn integration #3521

Merged
merged 15 commits into from
May 23, 2024

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented May 15, 2024

Changes

This PR introduces a blogpost about the possible future integration of Argo and Keptn. It describes how these two projects can collaborate and help the end user with faster and safer delivery of software

Part-of: #3356

@github-actions github-actions bot added documentation Improvements or additions to documentation ops labels May 15, 2024
@odubajDT odubajDT marked this pull request as ready for review May 15, 2024 10:48
@odubajDT odubajDT requested review from a team as code owners May 15, 2024 10:48
Copy link
Member

@bacherfl bacherfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! left a couple of suggestions but looks good already

docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.33%. Comparing base (e044b51) to head (6df8642).

Current head 6df8642 differs from pull request most recent head 45ea026

Please upload reports for the commit 45ea026 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3521      +/-   ##
==========================================
- Coverage   85.38%   85.33%   -0.06%     
==========================================
  Files         167      167              
  Lines        7412     7412              
==========================================
- Hits         6329     6325       -4     
- Misses        796      799       +3     
- Partials      287      288       +1     

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 58.04% <ø> (-0.33%) ⬇️
lifecycle-operator 83.46% <ø> (ø)
metrics-operator 88.32% <ø> (ø)
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
bacherfl
bacherfl previously approved these changes May 17, 2024
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done! I left a few minor suggestions for your consideration

docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
docs/blog/posts/argocd-keptn-health.md Outdated Show resolved Hide resolved
@odubajDT
Copy link
Contributor Author

Very nicely done! I left a few minor suggestions for your consideration

Thank you for your review :)

odubajDT and others added 13 commits May 22, 2024 10:07
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]>
Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
odubajDT and others added 2 commits May 22, 2024 10:10
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@StackScribe
Copy link
Contributor

Should this PR have at least a bit of a description, to set a good example for other contributors if nothing else. It might also be nice if it linked to #3356 just so that issue has a comprehensive list of the work that's been done.

@odubajDT odubajDT merged commit 1a34801 into keptn:main May 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants