Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lifecycle-operator): introduce RestApiEnabled parameter in KeptnConfig #3620

Merged
merged 6 commits into from
Jul 29, 2024

Conversation

asamonik
Copy link
Contributor

@asamonik asamonik commented Jul 29, 2024

Description

Adds a feature flag for the Rest Api

Fixes #3594

Checklist

  • My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
    into multiple PRs)
  • I used descriptive commit messages to help reviewers understand my thought process
  • I signed off all my commits according to the Developer Certificate of Origin (DCO)
    see Contribution Guide
  • My PR title is formatted according to the semantic PR conventions described in
    the Contribution Guide
  • My code follows the style guidelines of this project (golangci-lint passes, YAMLLint passes)
  • I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation (if needed)
  • My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)
  • New and existing unit and integration tests pass locally with my changes

Signed-off-by: asamonik <[email protected]>
Signed-off-by: asamonik <[email protected]>
Signed-off-by: asamonik <[email protected]>
@asamonik asamonik requested a review from a team as a code owner July 29, 2024 07:20
@asamonik asamonik marked this pull request as draft July 29, 2024 07:21
@asamonik asamonik changed the title Draft: feat: RestApi Feature Flag feat: RestApi Feature Flag Jul 29, 2024
@asamonik asamonik changed the title feat: RestApi Feature Flag RestApi Feature Flag Jul 29, 2024
@asamonik asamonik changed the title RestApi Feature Flag feat: RestApi Feature Flag Jul 29, 2024
@asamonik asamonik changed the title feat: RestApi Feature Flag feat(lifecycle-operator): rest API Feature Flag Jul 29, 2024
@asamonik asamonik marked this pull request as ready for review July 29, 2024 07:30
Signed-off-by: asamonik <[email protected]>
@odubajDT odubajDT changed the title feat(lifecycle-operator): rest API Feature Flag feat(lifecycle-operator): introduce RestApiEnabled parameter in KeptnConfig Jul 29, 2024
odubajDT
odubajDT previously approved these changes Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.44%. Comparing base (490b2be) to head (7ca0e00).
Report is 127 commits behind head on main.

Files with missing lines Patch % Lines
...cycle-operator/controllers/common/config/config.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3620      +/-   ##
==========================================
- Coverage   85.54%   85.44%   -0.10%     
==========================================
  Files         167      167              
  Lines        7414     7419       +5     
==========================================
- Hits         6342     6339       -3     
- Misses        787      794       +7     
- Partials      285      286       +1     
Files with missing lines Coverage Δ
...ator/controllers/options/keptnconfig_controller.go 85.00% <100.00%> (+0.38%) ⬆️
...cycle-operator/controllers/common/config/config.go 88.23% <0.00%> (-11.77%) ⬇️

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 58.04% <ø> (-0.33%) ⬇️
lifecycle-operator 84.62% <20.00%> (-0.08%) ⬇️
metrics-operator 88.32% <ø> (ø)
scheduler 34.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies
Copy link
Member

mowies commented Jul 29, 2024

@asamonik please regenerate the CRD docs, like described here

Signed-off-by: asamonik <[email protected]>
@asamonik asamonik requested a review from a team as a code owner July 29, 2024 11:00
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 29, 2024
Signed-off-by: asamonik <[email protected]>
Copy link

sonarcloud bot commented Jul 29, 2024

@asamonik asamonik requested a review from odubajDT July 29, 2024 11:30
@odubajDT odubajDT merged commit 1ab1f14 into keptn:main Jul 29, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lifecycle-operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Keptn/Argo REST API client feature flag to KeptnConfig
3 participants