Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolute links to webdiplomacy.net (and other references) #651

Open
diptobi1 opened this issue Feb 25, 2020 · 0 comments
Open

Absolute links to webdiplomacy.net (and other references) #651

diptobi1 opened this issue Feb 25, 2020 · 0 comments

Comments

@diptobi1
Copy link
Contributor

I just noticed, that there are currently direct links to the main web dip server. Even if you are on a fork like vdip.

Take the following picture of how the registration mail for vdip currently looks:

RegistrationMail

(Ignore the lower half. There is apparently still an issue with the last code merge.)

The link to the rules and the password finder are hard coded (though the latter was already changed in the past). As a suggestion it would be much better to make it dynamic as it is already the case for the validation address (e.g. with $_SERVER['SERVER_NAME']).
The link to the webdip discord server is hard-coded, too. That could be put to the configs, perhaps?

Additionally, what would be a very neat feature for the future, though certainly not that urgent, would be a configurable website name set in the configs. Then all appearances of "webDiplomacy" could be replaced by the config variable. That would make customizing webdip much easier for forks.
After the last code merges on vdip the references to vDiplomacy and webDiplomacy are quite a mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant