Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move order submission response from header to actual content in ajax.php #652

Open
diptobi1 opened this issue Feb 26, 2020 · 0 comments
Open

Comments

@diptobi1
Copy link
Contributor

Currently, when a users saves their orders, the server replies to the ajax request with a response, which is completely written into a customized HTTP-header instead of the actual content.

This method is nowadays deprecated (https://tools.ietf.org/html/rfc6648) and has as one drawback that the header size is usually limited to small data sizes (~ 8 KB) by default server configurations. Though, as the response also includes the order data, custom variants where users might get many units (~100) are just scraping at the 8 KB size limit.

It is probably the cleanest and not too complicated to just move the ajax-json-response to the actual content of the response and use a standard application/json content header as it is the common practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant