Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages incompatible with non-windows #26

Open
iskiselev opened this issue Aug 15, 2015 · 6 comments
Open

Packages incompatible with non-windows #26

iskiselev opened this issue Aug 15, 2015 · 6 comments

Comments

@iskiselev
Copy link

In Grunt, Gulp and Bower packages hardcoded ".cmd" in command file name.
It is incompatible with Linux - there will be no extension for commands at all.

As Node/Npm packages use commands without .cmd extension, they correctly works on Linux (if $NodeJS environment variable provided).

@kevicency
Copy link
Owner

I guess there are more issues than the hard-coded .cmd when it comes to getting this to work on Linux. I also don't plan on adding support for it, but you are free to add a pull request :)

@iskiselev
Copy link
Author

I was able to run everything else on Unix when I removed .cmd and check for presence of files.

@kevicency
Copy link
Owner

Interesting. Guess it works when it doesn't try to find the executables using where.exe. Do you know a way to find out which OS MSBuild is running on?

@kevicency kevicency reopened this Sep 14, 2015
@iskiselev
Copy link
Author

Something like:

  <PropertyGroup Condition=" '$(OS)' == 'Windows_NT' ">
    <DefineConstants>$(DefineConstants);WINDOWS</DefineConstants>
  </PropertyGroup>
  <PropertyGroup Condition=" '$(OS)' == 'Unix' ">
    <DefineConstants>$(DefineConstants);UNIX</DefineConstants>
  </PropertyGroup>
  <PropertyGroup Condition=" '$(OS)' == 'OSX' ">
    <DefineConstants>$(DefineConstants);OSX</DefineConstants>
  </PropertyGroup>

@iskiselev
Copy link
Author

Here is my modified version of targets: https://github.com/sq/JSIL/tree/master/JSIL.Libraries/Targets
Here you can look on logs of executing them successfully on Unix: https://travis-ci.org/iskiselev/JSIL/builds/80366771

@iskiselev
Copy link
Author

In Unix call to where,exe probably should be replaced with which

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants