Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View cut off on 4:3 monitor #575

Closed
nyquist2205 opened this issue Feb 15, 2019 · 8 comments · Fixed by Keleo/CustomCSSBundle#5
Closed

View cut off on 4:3 monitor #575

nyquist2205 opened this issue Feb 15, 2019 · 8 comments · Fixed by Keleo/CustomCSSBundle#5
Labels
feature request plugin not meant to be implemented in the core, but could be a plugin

Comments

@nyquist2205
Copy link

Describe the bug
On 4:3 monitors, the right side of the "My Times" view is cut off. In a way that you can't access the "Actions" buttons.

kimai

To Reproduce
Steps to reproduce the behavior:

  1. Get a PC with 4:3 screen
  2. Go to Kimai2 Demo site

Expected behavior
I think horizontal scrollbars would be okay as 4:3 monitors are not really the standard anymore.

Desktop (please complete the following information):

  • OS: Windows 7 Pro
  • up to date Chrome and Firefox

Additional context
Sure, 4:3 screens are rare now, but i have one at my workshop and can't stop a running entry this way...

@kevinpapst
Copy link
Member

kevinpapst commented Feb 15, 2019

Uff, thats a hard one.
I already wrote in the requirement section

A modern browser, Kimai v2 might be broken on old browsers like IE 10

Probably I should extend it to:

A modern monitor ;-)

An easy solution is to use the "column filter" which you can access in the upper right via the eye icon.
Simply hide project and description?

Edit: and you are using the demo, which creates quite long fake data.

@nyquist2205
Copy link
Author

Yes, i know my monitor is oudated a bit... But espacially in workshops/labs they still can be seen as fixed ones on a shelf.

But okay, if its hard to fix (I'm not into it too much) the workaround with hiddens columns will work. Because even in my "production" environment there are several longer entrys so the actions are hidden.

@kevinpapst
Copy link
Member

kevinpapst commented Feb 15, 2019

Hm, good argument. I didn't say I can't or don't want to fix it.
It just never occurred to me that someone would use horizontal scrolling.

Can you do me a favor and test that in your installation:

There won't be scrollbars, but you should be able to swipe the table.

@nyquist2205
Copy link
Author

So, tried it out right now. This creates a horizontal scrollbar with every monitor setup (15" laptop, 24" desktop, 19" 4:3 monitor).
I like it for the 4:3 one, but you're right, on the "normal" ones it's not really state of the art. Maybe activate this only for screens under a specific width? Or really based on the ratio?

This is the 4:3 one (sorry, had to hide my information...):
kimai

@kevinpapst
Copy link
Member

Ok, good to know that this could be one option to solve this problem.
Lets wait if there is more user feedback in the next time. I wonder why I didn't saw any scrollbars, no matter how small I resized my window...

I will think about how this could be integrated as plugin or setting - this shouldn't be activated by default IMO.

@kevinpapst kevinpapst added feature request plugin not meant to be implemented in the core, but could be a plugin labels Feb 16, 2019
@nyquist2205
Copy link
Author

nyquist2205 commented Feb 16, 2019

I wonder why I didn't saw any scrollbars, no matter how small I resized my window...

Maybe that's because I've the release 0.7 installed and none of the newer commits. I've also seen some differences in the datatables.html.twig.

But ok, I'm fine now, having the scrollbar - thanks ;-)

@kevinpapst
Copy link
Member

kevinpapst commented Apr 29, 2019

With the latest release 0.9 you can install the CustomCSS extension:
https://www.kimai.org/store/keleo-css-custom-bundle.html

There is a CSS rule included which activates the responsive table, so you don't have to edit the template.
Another rule changes the customer/project/activity labels: they are allowed to "wrap", so they might line-break to avoid taking up too much space.

@lock
Copy link

lock bot commented Jun 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request plugin not meant to be implemented in the core, but could be a plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants