Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resize mobile navbar buttons #582

Closed
j0hannesr0th opened this issue Feb 19, 2019 · 8 comments · Fixed by #583
Closed

resize mobile navbar buttons #582

j0hannesr0th opened this issue Feb 19, 2019 · 8 comments · Fixed by #583
Labels
Milestone

Comments

@j0hannesr0th
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The menu on mobile devices such as the Samsung Galaxy S9/S9+ is in two rows.

grafik

Describe the solution you'd like
Make the size of the buttons/icons in the mobile navbar a bit smaller that they fit in one row.

Changing the font-size of the navbar to 9pt instead of 14pt did the trick:
grafik

@kevinpapst
Copy link
Member

Thanks for the info! Will be adjusted

@kevinpapst kevinpapst added the bug label Feb 19, 2019
@kevinpapst kevinpapst added this to the 0.9 milestone Feb 19, 2019
@kevinpapst
Copy link
Member

Okay, I am almost there... but one question:
you say, you decreased the size from 14pt to 9pt.
When I check the elements, I can only see a font-size of 14px for the link.
And decreasing it to 12px was enough to stop it from breaking.

@j0hannesr0th
Copy link
Contributor Author

Hm, I used the arrow keys to count down the font size and it was good at 9. Maybe the view didn't update as fast as i counted down the value.

@kevinpapst
Copy link
Member

I was more curious about pt vs px, but doesn't matter.
I updated the size and padding, should. be good on mobile and desktop now.

@j0hannesr0th
Copy link
Contributor Author

j0hannesr0th commented Feb 19, 2019

I've tested it and it looks good. What do you think about removing the headline above the nav bar in mobile view? Especially on small devices - such as the iPhone 5/5S - there will be more space for the actual app.

grafik

It refers to /homepage which forwards to /timesheet

@kevinpapst
Copy link
Member

Actually it forwards to your setting "Initial view after login", so it could be the calendar as well.
I am not sure about removing it, but go ahead and open a new issue and we see what others think about it. I am planning to finally adopt a plugin system and this feature (hide mobile header) could be a simple one...

@kevinpapst
Copy link
Member

kevinpapst commented Feb 19, 2019

Oh and thanks for testing! Too bad we just found that bug after the release ;-)

@lock
Copy link

lock bot commented Apr 21, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Apr 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants