Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hungarian translation #897

Closed
kevinpapst opened this issue Jul 1, 2019 · 8 comments
Closed

Update Hungarian translation #897

kevinpapst opened this issue Jul 1, 2019 · 8 comments
Labels
help wanted needs a developer who want to add this feature
Milestone

Comments

@kevinpapst
Copy link
Member

kevinpapst commented Jul 1, 2019

The following translations are missing from hu currently:

$ bin/console debug:translation --only-missing hu
 ----------- --------------- ----------------------------- ----------------------------- ------------------------------------------ 
  State       Domain          Id                            Message Preview (hu)          Fallback Message Preview (en)             
 ----------- --------------- ----------------------------- ----------------------------- ------------------------------------------ 
   missing    messages        recent.activities             recent.activities             Restart one of your last activities       
   missing    messages        active.entries                active.entries                Your active time measurements             
   missing    messages        admin_entity.delete_confirm   admin_entity.delete_confirm   This data will be deleted as well! Al...  
   missing    messages        label.timeBudget              label.timeBudget              Time budget                               
   missing    about           support                       support                       Support                                   
   missing    about           donate                        donate                        Donate for the future of Kimai            
   missing    about           published_under               published_under               %kimai% is published under                
   missing    about           special_thanks                special_thanks                Special thanks go to …                    
   missing    about           library_authors               library_authors               … the authors of the following softwa...  
   missing    flashmessages   timesheet.locked.warning      timesheet.locked.warning      You are editing an exported record        
   missing    flashmessages   warning                       warning                       Warning                                   
   missing    plugins         plugins.title                 plugins.title                 Plugins                                   
   missing    plugins         plugins.subtitle              plugins.subtitle              You can enhance the functionality of ...  
   missing    plugins         plugin.none_installed         plugin.none_installed         You have no plugin installed yet.         
   missing    tags            tags.title                    tags.title                    Tags                                      
   missing    tags            tags.subtitle                 tags.subtitle                 Tags allow, to freely combine timeshe...  
 ----------- --------------- ----------------------------- ----------------------------- ------------------------------------------ 

There might be more, the debug command cannot find all missing translations.

@kevinpapst kevinpapst added the help wanted needs a developer who want to add this feature label Jul 1, 2019
@kevinpapst
Copy link
Member Author

@infeeeee do you have time & think you can help with this one before I release 1.0?

@infeeeee
Copy link
Contributor

infeeeee commented Jul 1, 2019

doing it right now!

@kevinpapst
Copy link
Member Author

Awesome, thank you so much!

@infeeeee
Copy link
Contributor

infeeeee commented Jul 1, 2019

I just found that options in the dropdowns on editing time records, projects etc are not translatable:

image

This screenshot is from the customers page, language set to Hungarian

If you weren't aware of this, I can open a new issue for this.

@kevinpapst
Copy link
Member Author

Yes they are: https://github.com/kevinpapst/kimai2/blob/master/translations/actions.en.xliff

The translation cache is very annoying and sometimes won't update.
If you add a new translation file, you should delete the cache manually rm -rf var/cache/*. For me cache:clear doesn't help.

@infeeeee
Copy link
Contributor

infeeeee commented Jul 1, 2019

Than it is a bug in the translation checker! actions.hu.xliff doesn't exist, however bin/console debug:translation --only-missing hu shows nothing

Please don't accept my PR, this file is missing

@kevinpapst
Copy link
Member Author

Ah right, yeah this tool is a little dumb. It only finds translation strings that are hardcoded in the templates.
But if the translation strings are dynamically created like "actions." + "trash" then they don't show up.

The only way to see the missing translations correctly is by using the "dev" environment and then checking the red "missing translations" debug toolbar.

@kevinpapst kevinpapst added this to the 1.0 milestone Jul 1, 2019
@lock
Copy link

lock bot commented Aug 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted needs a developer who want to add this feature
Projects
None yet
Development

No branches or pull requests

2 participants