Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javascript and api to stop and display active records #772

Merged
merged 13 commits into from
May 10, 2019

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented May 9, 2019

Description

Additional changes

  • added system config to switch select-box type via UI
  • use datatable macro to render plugin table

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

@kevinpapst kevinpapst added this to the 1.0 milestone May 9, 2019
# Conflicts:
#	templates/macros/actions.html.twig
@kevinpapst
Copy link
Member Author

@infeeeee @hmr-it-jr and everyone else: I'd like to ask you, if you could help me with some testing? This is a follow up on the durations in title issue. Well actually it is much more ... but this was fixed together with all the additional changes mentioned in the PR description.

I installed the branch at https://demo-branch.kimai.org/ so its simpler to test .

@j0hannesr0th
Copy link
Contributor

It works for me:
grafik

grafik

grafik

If the Kimai 2 tab is not focused it works, too. So well done!

@rarvin
Copy link

rarvin commented May 10, 2019 via email

@kevinpapst
Copy link
Member Author

Guys, you rock 🎉 thanks for your feedback!

@kevinpapst kevinpapst merged commit 09da7cd into master May 10, 2019
@kevinpapst kevinpapst deleted the active-records-js branch May 10, 2019 11:45
@lock
Copy link

lock bot commented Jul 9, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Jul 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor active entries dropdown Stop entries without page reload
3 participants