-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
javascript and api to stop and display active records #772
Conversation
# Conflicts: # assets/js/KimaiLoader.js # public/build/app.css # public/build/app.js # public/build/manifest.json
# Conflicts: # templates/macros/actions.html.twig
@infeeeee @hmr-it-jr and everyone else: I'd like to ask you, if you could help me with some testing? This is a follow up on the durations in title issue. Well actually it is much more ... but this was fixed together with all the additional changes mentioned in the PR description. I installed the branch at https://demo-branch.kimai.org/ so its simpler to test . |
Dear Kevin,
I have also done a test through the demo url and can confirm that it works
well.
Tried for multiple tasks the status updates
Tried for individual tasks the status updates
Tried for multiple tasks and then stopped one task in them, could see that
the status of the stopped one vanishes, where as the one active the status
updates.
Tried adding a task when other two are active, the third task also gets
added and its status appears.
Tried adding more than 3 at a time, the notification that three active
tasks are stated is shown, the status is still updated for the 3 tasks
active.
Logged out and logged in and could see the status
Even when the focus of the cursor is not against the said browser screen or
the browser is in the background could see the status updating.
Regards
Aravind
…On Fri, May 10, 2019 at 10:58 AM hmr-it-jr ***@***.***> wrote:
It works for me:
[image: grafik]
<https://user-images.githubusercontent.com/36242595/57504449-cf7a5b80-72f4-11e9-80ad-58a1f3ebb89e.png>
[image: grafik]
<https://user-images.githubusercontent.com/36242595/57504470-ecaf2a00-72f4-11e9-9c62-570c80ddf6cc.png>
[image: grafik]
<https://user-images.githubusercontent.com/36242595/57504510-0f414300-72f5-11e9-8958-1570c2a5bd25.png>
If the Kimai 2 tab is not focused it works, too. So well done!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#772 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMA3M7W2IOSKDI6BUVYG6ULPUUBWNANCNFSM4HL6Y7DQ>
.
|
Guys, you rock 🎉 thanks for your feedback! |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai. |
Description
Additional changes
Types of changes
Checklist
bin/console kimai:codestyle --fix
to verify the correct code style(https://github.com/kimai/www.kimai.org/tree/master/_documentation) accordingly