Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added installation command #838

Merged
merged 14 commits into from
Jun 4, 2019
Merged

added installation command #838

merged 14 commits into from
Jun 4, 2019

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Jun 4, 2019

Description

Adds the command bin/console kimai:install which serves as interactive method to install Kimai.

Having a dedicated command:

  • simplifies the documentation
  • makes sure users cannot skip single steps
  • should prevent user errors
  • decrease support requests regarding the installation

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #838 into master will decrease coverage by 0.39%.
The diff coverage is 68.64%.

@@             Coverage Diff             @@
##             master     #838     +/-   ##
===========================================
- Coverage     93.66%   93.26%   -0.4%     
- Complexity     2127     2165     +38     
===========================================
  Files           227      229      +2     
  Lines          6821     6939    +118     
===========================================
+ Hits           6389     6472     +83     
- Misses          432      467     +35
Impacted Files Coverage Δ Complexity Δ
src/Doctrine/UTCDateTimeType.php 100% <100%> (ø) 9 <1> (+1) ⬆️
src/Utils/File.php 100% <100%> (ø) 2 <2> (?)
src/Command/InstallCommand.php 66.96% <66.96%> (ø) 35 <35> (?)
src/Doctrine/TimesheetSubscriber.php 100% <0%> (+8%) 11% <0%> (ø) ⬇️

@kevinpapst kevinpapst merged commit 325d204 into master Jun 4, 2019
@kevinpapst kevinpapst deleted the install-command branch June 4, 2019 21:51
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant