Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added LDAP config to set filter for finding user attributes #877

Merged
merged 1 commit into from
Jun 23, 2019

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Jun 22, 2019

Description

Fixes #875

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added the bug label Jun 22, 2019
@kevinpapst kevinpapst added this to the 1.0 milestone Jun 22, 2019
@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

Merging #877 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #877   +/-   ##
=========================================
  Coverage     94.29%   94.29%           
  Complexity     2453     2453           
=========================================
  Files           262      262           
  Lines          7724     7724           
=========================================
  Hits           7283     7283           
  Misses          441      441
Impacted Files Coverage Δ Complexity Δ
src/Ldap/LdapManager.php 96.42% <100%> (-0.07%) 22 <0> (ø)
src/DependencyInjection/Configuration.php 98.73% <100%> (ø) 22 <0> (ø) ⬇️

@kevinpapst kevinpapst merged commit 7b95750 into master Jun 23, 2019
@kevinpapst kevinpapst deleted the active-directory-filter branch June 23, 2019 10:38
@lock
Copy link

lock bot commented Aug 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication to Active Directory
1 participant