Only process PCAPs with httpreplay when tlsdump.log exists #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes prevent PCAPs from being processed by httpreplay (Pcap2 processing module) when there are not TLS keys available. This is because httpreplay processing is very time intensive due to its pure-python implementation. Httpreplay's core use is to decrypt TLS traffic so it can be processed by Suricata. If there are no TLS keys available, there is no requirement to use it for processing. For context, when CAPE attempted to process a ~250MB PCAP with httpreplay, it took ~960 seconds. Without httpreplay, it took ~16 seconds.
gitworkflows
pushed a commit
to threatcode/CAPEv2
that referenced
this pull request
Sep 10, 2024
* Update callback.py * Update callback.py * Package summary/description in UI (kevoreilly#2313) - Following on from kevoreilly#2220 now we display the package summary and description in the UI - In views.py: - Added code to parse the python analysis package modules, pulling out summary and description - Updated `get_form_data()` to return list of dicts, not list of strings - When sorting the package names, no longer be case sensitive - Updated the `submission/index.html` template to expect a dict per package - Added some tests - Tweak to `web/settings.py` so it can find the templates, even during test execution * Update cape2.sh * Add SslKeyLogFile aux module and PcapNg processing module (kevoreilly#2312) * Add SslKeyLogFile aux module and PcapNg processing module SslKeyLogFile sets the SSLKEYLOGFILE environment var on the guest and collects the resulting log file. This is especially useful when detonating inside of browsers. PcapNg takes SSL/TLS keys from tlsdump.log and SslKeyLogFile and injects them into the detonation PCAP using the `editcap` binary. The file is made available to download via the UI. * Update views.py * style: Automatic code formatting * Monitor update: Add capability to dynamically unhook previously hooked functions (unhook-apis option takes colon-separated list e.g. unhook-apis=NtSetInformationThread:NtDelayExecution) * Themida detonation shim * Update index.html * Update submit.rst * Only process PCAPs with httpreplay when tlsdump.log exists (kevoreilly#2315) These changes prevent PCAPs from being processed by httpreplay (Pcap2 processing module) when there are not TLS keys available. This is because httpreplay processing is very time intensive due to its pure-python implementation. Httpreplay's core use is to decrypt TLS traffic so it can be processed by Suricata. If there are no TLS keys available, there is no requirement to use it for processing. For context, when CAPE attempted to process a ~250MB PCAP with httpreplay, it took ~960 seconds. Without httpreplay, it took ~16 seconds. * style: Automatic code formatting * Stealc detection: loosen yara pattern slightly --------- Co-authored-by: doomedraven <[email protected]> Co-authored-by: Robin Koumis (SecureWorks) <[email protected]> Co-authored-by: Josh Feather <[email protected]> Co-authored-by: GitHub Actions <[email protected]> Co-authored-by: Kevin O'Reilly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes prevent PCAPs from being processed by httpreplay (Pcap2 processing module) when there are no TLS keys available. This is because httpreplay processing is very time intensive due to its pure-python implementation.
Httpreplay's core use is to decrypt TLS traffic so it can be processed by Suricata. If there are no TLS keys available, there is no requirement to use it for processing.
For context, when CAPE attempted to process a ~250MB PCAP with httpreplay, it took ~960 seconds. Without httpreplay, it took ~16 seconds.
Related to #2314