Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLD tracker endcaps too small in CED #355

Closed
Zehvogel opened this issue Jul 17, 2024 · 2 comments · Fixed by #362
Closed

CLD tracker endcaps too small in CED #355

Zehvogel opened this issue Jul 17, 2024 · 2 comments · Fixed by #362

Comments

@Zehvogel
Copy link
Contributor

They are the right size in geoDisplay. @gaede @tmadlener you recently fixed the shape, do you also have an idea what we can do about the size? :)

The outer radius should roughly match the grey lines

image

@tmadlener
Copy link
Contributor

I tried to figure out where the necessary changes would need to happen, resp. where the issue could actually be, but I am not yet sure which part of the whole CED ecosystem is actually responsible for drawing the detector.

@Zehvogel
Copy link
Contributor Author

Ah sorry I could have provided a bit more info. I would guess that there is still something wrong with the ZDiskPetalsData used here to determine the dimensions for drawing.

https://github.com/iLCSoft/MarlinUtil/blob/bde10dc7da50a22503b0593f9188d2be047fbebf/source/src/DDMarlinCED.cc#L582-L597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants