Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(web): unnecessary flicker on banner while typing #7162

Closed
Tracked by #7161
mcdurdin opened this issue Aug 30, 2022 · 3 comments
Closed
Tracked by #7161

bug(web): unnecessary flicker on banner while typing #7162

mcdurdin opened this issue Aug 30, 2022 · 3 comments
Milestone

Comments

@mcdurdin
Copy link
Member

mcdurdin commented Aug 30, 2022

Describe the bug

From a team review of the Keyman for Android UX (#7161)

Even if suggestions remain the same, they blink out, then in again on each keystroke. It causes a flicker that is quite distracting while typing two-thumbs, and shouldn't be necessary!

Expected behavior

No flicker -- we should not see a blank unless we actually have no suggestions available. Perhaps delay updating the banner until the next suggestion lookup completes?

Screenshots

In the following video, I am typing slowly but you can see how the suggestions disappear and reappear with each keystroke, even if they don't change. Particularly noticeable on backspace.

Screen_Recording_20220831-043504_Keyman.mp4

Related issues


Keyman for Windows/macOS/Linux/iPhone/iPad/Android:

  • Device: Samsung A90 5G
  • OS: Android 12
  • Keyman version: 15.0.269-stable
@mcdurdin mcdurdin added this to the 17.0 milestone Aug 31, 2022
@mcdurdin mcdurdin changed the title bug(android): unnecessary flicker on banner while typing bug(web): unnecessary flicker on banner while typing Dec 9, 2022
@mcdurdin mcdurdin added web/ and removed android/ labels Dec 9, 2022
@mcdurdin mcdurdin modified the milestones: 17.0, Future Dec 9, 2022
@mcdurdin
Copy link
Member Author

This seems to me to be adequately addressed in v17.0. @jahorton do you know which PR would have resolved this?

@mcdurdin mcdurdin modified the milestones: Future, B17S2 Feb 26, 2024
@jahorton
Copy link
Contributor

I'd have to go digging and experimenting in order to tell. I'm not even sure if it was the gesture work (🐵) or the ES-modularization work (🧩) that would have fixed it... though likely the latter.

I did note the link mentioned above for a 🧩 PR, but I can't find an actual comment referring to this one from there.

@mcdurdin
Copy link
Member Author

Fixed by #8544 or related PRs.

(Note the "619 hidden items" 😨 on that PR means that the reference to this issue will be somewhere in that conversation history I guess!)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants