Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Displayed contributions don't match calculated contributions #449

Open
ermshiperete opened this issue May 27, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ermshiperete
Copy link
Contributor

The contributions displayed on the status site don't always match the calculated contributions (notice the red 1 after "Contributions", but nothing showing up below):

image

This is on a machine with the time zone set to Germany (UTC+2). On a machine with Phnom Penh time zone (UTC+7) one review shows up:

image

The comment in #11535 was made on Friday at 19:03 German time (Saturday 0:03 Phnom Penh).

It looks like contributions are calculated based on Phnom Penh time, but displayed in local time.

It would be good if server and client would agree, i.e. if the client would always display contributions based on the same time zone as the server. This might lead to some contributions showing up on the "wrong" day. The reasoning behind this would be that the days displayed would be Phnom Penh time.

Another solution would be to show the days in local time but for the full sprint (starting at 0:00 Phnom Penh on Saturday and ending 23:59 Phnom Penh on Friday). This would lead to showing 15 days for a sprint for non-Phnom Penh time zones.

@ermshiperete
Copy link
Contributor Author

That might not be the only thing going on. It doesn't explain why PR #11536 isn't considered as contribution which was created on Friday 19:14 UTC+2 (Saturday 0:14 UTC+7). Or maybe that is because it was labeled as A18S2 (previous sprint) when it was created?

@mcdurdin mcdurdin added this to the A18S3 milestone May 29, 2024
@mcdurdin mcdurdin added the bug Something isn't working label May 29, 2024
@mcdurdin mcdurdin self-assigned this May 29, 2024
@mcdurdin mcdurdin modified the milestones: A18S3, A18S4 Jun 7, 2024
@darcywong00 darcywong00 modified the milestones: A18S4, A18S5 Jun 21, 2024
@mcdurdin mcdurdin modified the milestones: A18S5, A18S7 Jul 5, 2024
@darcywong00 darcywong00 modified the milestones: A18S7, A18S8 Aug 2, 2024
@darcywong00 darcywong00 modified the milestones: A18S8, A18S9 Aug 17, 2024
@darcywong00 darcywong00 modified the milestones: A18S9, A18S10 Aug 31, 2024
@darcywong00 darcywong00 modified the milestones: A18S10, A18S11 Sep 14, 2024
@darcywong00 darcywong00 modified the milestones: A18S11, A18S12 Sep 28, 2024
@darcywong00 darcywong00 modified the milestones: A18S12, A18S13 Oct 11, 2024
@darcywong00 darcywong00 modified the milestones: A18S13, A18S14 Oct 26, 2024
@mcdurdin mcdurdin modified the milestones: A18S14, A18S19 Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants